lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tatu Saloranta <t...@hypermall.net>
Subject Re: [PATCH] Refactoring QueryParser.jj, setLowercaseWildcardTerms()
Date Mon, 24 Feb 2003 14:19:43 GMT
On Sunday 23 February 2003 21:41, Otis Gospodnetic wrote:
> Hello,
>
> --- Doug Cutting <cutting@lucene.com> wrote:
> > +1
> >
> > I like this approach of modifying the query parser through
> > subclassing.
> >
> > We should consider taking this approach further, e.g., perhaps by
> > making
> > addClause(), getFieldQuery() and getRangeQuery() into protected
> > methods,
> > so that folks can modify their behavior too.  Thoughts?
>
> I don't see a problem with that. +1.
>
> > Also, I think we should lowercase prefix and wildcard queries by
> > default.  This would fix one of the most frequently reported
> > problems.
...
> > to complain about the default case-sensitivity of wildcard searches.
> > What do others think?
>
> I'm pro lowercase! :)
> Tatu, are you okay with that?

Sure, no problem. I just wasn't sure what should be the default, so started 
with backward compatibility. :-)

There are ways to make this even more reliable, for example analyzer could 
have a method for checking if it always does lowercasing 
('isLowerCaseFilter()' or such), but perhaps that'd be an overkill.

It's probably ok to default to lower-casing; deriving classes can override the 
methods to change behaviour.

-+ Tatu +-


---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message