Return-Path: Delivered-To: apmail-jakarta-lucene-dev-archive@apache.org Received: (qmail 99241 invoked from network); 6 Jan 2003 19:07:26 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 6 Jan 2003 19:07:26 -0000 Received: (qmail 5453 invoked by uid 97); 6 Jan 2003 19:08:45 -0000 Delivered-To: qmlist-jakarta-archive-lucene-dev@jakarta.apache.org Received: (qmail 5435 invoked by uid 97); 6 Jan 2003 19:08:45 -0000 Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Lucene Developers List" Reply-To: "Lucene Developers List" Delivered-To: mailing list lucene-dev@jakarta.apache.org Received: (qmail 5423 invoked by uid 98); 6 Jan 2003 19:08:44 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Message-ID: <3E19D429.7070802@lucene.com> Date: Mon, 06 Jan 2003 11:08:25 -0800 From: Doug Cutting User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2) Gecko/20021202 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Lucene Developers List Subject: Re: Should Token be immutable? References: <187D6D956106D84E9D8B280F6458FE140F5ADF@merc12.na.sas.com> <20021212123737.A5924@lx.quiotix.com> <5.1.0.14.2.20021230234131.04150ea0@pop.quiotix.com> <3E19C426.4010205@lub.umontreal.ca> In-Reply-To: <3E19C426.4010205@lub.umontreal.ca> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N stephane vaucher wrote: > 1) Does anyone mind? Will it break anything? It shouldn't break anything. > 2) Are there units tests for this? (particularly PorterStemFilter). The > changes are obviously not spectacular, but I prefer not to screw > everyone up... I don't know of any unit tests specifically for this. Mostly this change will affect compilation. In general though, if you don't see unit tests for things that you think you might break, then it never hurts to write more unit tests. > 3) I've checked-out the latest version of lucene, is there anything > special I need to do if I get the go ahead to check my stuff in (like a > dev list review)? If you're not a regular committer then please send diffs to lucene-dev before comitting and give folks a few days to consider the changes. Doug -- To unsubscribe, e-mail: For additional commands, e-mail: