lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kristian Hermsdorf <kristian.hermsd...@ifbus.de>
Subject Re: bug in escaping special characters
Date Wed, 29 Jan 2003 08:41:00 GMT
Hi

I'll have a look to the "\\"-problem (think I really missed that point) an 
will run test's again....
I'm afraid it could take some time.

bye

Kristian

On Sat, 25 Jan 2003 21:07:37 -0800 (PST), Otis Gospodnetic 
<otis_gospodnetic@yahoo.com> wrote:

> Sorry, I'm not sure if I follow everything you said, but judging from
> that JUnit output in your message it looks like your changes now just
> get rid of _all_ \ characters, which is, I believe, wrong.
> "\\" is a "\" escaped with a "\".  In this case the second "\" needs to
> remain, and your modifications eliminate it, and JUnit tests start
> failing.
> Anyhow, what problem are you trying to fix?
>
> Otis
>
>
> --- Kristian Hermsdorf <kristian.hermsdorf@ifbus.de> wrote:
>> Hi Otis
>>
>> unfortunately the junit-test weren't successful but I think they
>> might be incorrect or I misunderstand escaping.
>>
>> Though it seems to me, that the analyzer does affect the result of
>> the junit-test I don't understand why it does. I thought the tokens
>> produced by the analyzer should not contain the escaping-char anymore, 
>> does they?
>>
>> Should not result the query-string for \[something in a query for 
>> [something ?
>>
>> Maybee you could enlighten me, how the junit-test is meant and how
>> escaping should work.
>> thanks
>>
>> Kristian
>>
>>
>> public void testEscaped() throws Exception {
>> Analyzer a = new WhitespaceAnalyzer();
>> assertQueryEquals("\\[brackets", a, "\\[brackets");        ...fails
>> assertQueryEquals("\\[brackets", null, "brackets");        ...works
>> assertQueryEquals("\\\\", a, "\\\\");
>> assertQueryEquals("\\+blah", a, "\\+blah");
>> assertQueryEquals("\\(blah", a, "\\(blah");
>> }
>>
>> Query /\[brackets/ yielded /[brackets/, expecting /\[brackets/
>> junit.framework.AssertionFailedError: Query /\[brackets/ yielded 
>> /[brackets/, expecting /\[brackets/
>> 	at
>>
> org.apache.lucene.queryParser.TestQueryParser.assertQueryEquals(Unknown
>>
>> Source)
>> 	at org.apache.lucene.queryParser.TestQueryParser.testEscaped(Unknown
>>
>> Source)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> 	at
>>
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>> 	at
>>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>
>>
>>
>> On Wed, 22 Jan 2003 17:40:38 -0800 (PST), Otis Gospodnetic 
>> <otis_gospodnetic@yahoo.com> wrote:
>>
>> > Hello Kristian, thanks for the contribution.
>> >
>> > Two quick questions:
>> >
>> > 1. do all unit tests still pass after your changes? (ant test-unit)
>> > 2. could you please make the diff against the latest
>> QueryParser.jj?
>> > (it seems like your QueryParser.jj is from June 2002 :))
>> >
>> > Thanks!
>> > Otis
>> >
>> >
>> > --- Kristian Hermsdorf <kristian.hermsdorf@ifbus.de> wrote:
>> >> Hi everyone ...
>> >> I think I found a bug in lucene query mechanism. QueryParser does
>> >> mask spechial charakters but doesn't unmask them. So a search for
>> >> field:a\:b did really search for a\:b in field (and not for a:b).
>> >> I added a few lines in QueryParser.jj to fix this issue.
>> >> I also added ' ' to _ESCAPED_CHAR to enable searches like
>> >> field:hello\ world.
>> >> I attach QueryParser.jj and bugfix.diff and hope these changes
>> does
>> >> not collide with other thinks...
>> >>
>> >> bye
>> >> Kristian
>> >> -- ACRONYM: Acronym Causing Recursion, Obviously Numbing Your Mind
>> >> Kristian Hermsdorf
>> >> interface:projects gmbh
>> >> Tollkewitzer Straße  49
>> >> 01277 Dresden
>> >>
>> >> tel.: ++49-351-3 18 09 39
>> >> mail: Kristian.Hermsdorf@interface-business.de
>> >> priv: kristian@entropus.de
>> >
>> >> ATTACHMENT part 2 application/octet-stream name=QueryParser.jj
>> >
>> >
>> >> ATTACHMENT part 3 application/octet-stream name=bugfix.diff
>> >> --
>> >> To unsubscribe, e-mail:  <mailto:lucene-dev->> 
>> unsubscribe@jakarta.apache.org>
>> >> For additional commands, e-mail:
>> > <mailto:lucene-dev-help@jakarta.apache.org>
>> >
>> >
>> > __________________________________________________
>> > Do you Yahoo!?
>> > Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
>> > http://mailplus.yahoo.com
>> >
>> > --
>> > To unsubscribe, e-mail:   <mailto:lucene-dev-> 
>> unsubscribe@jakarta.apache.org>
>> > For additional commands, e-mail: <mailto:lucene-dev-> 
>> help@jakarta.apache.org>
>> >
>> >
>> >
>>
>>
>>
>> -- ACRONYM: Acronym Causing Recursion, Obviously Numbing Your Mind
>>
>> Kristian Hermsdorf
>>
>> interface:projects gmbh		
>> Tollkewitzer Straße  49		
>> 01277 Dresden			
>>
>>
>> tel.: ++49-351-3 18 09 39
>>
>> mail: Kristian.Hermsdorf@interface-business.de
>> priv: kristian@entropus.de
>>
>> --
>> To unsubscribe, e-mail:  <mailto:lucene-dev- 
>> unsubscribe@jakarta.apache.org>
>> For additional commands, e-mail:
>> <mailto:lucene-dev-help@jakarta.apache.org>
>>
>
>
> __________________________________________________
> Do you Yahoo!?
> Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
> http://mailplus.yahoo.com
>
> --
> To unsubscribe, e-mail:   <mailto:lucene-dev- 
> unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:lucene-dev- 
> help@jakarta.apache.org>
>
>
>



-- 
ACRONYM: Acronym Causing Recursion, Obviously Numbing Your Mind  

Kristian Hermsdorf

interface:projects gmbh		
Tollkewitzer Straße  49		
01277 Dresden			


tel.: ++49-351-3 18 09 39

mail: Kristian.Hermsdorf@interface-business.de
priv: kristian@entropus.de

---------------------------------------------------------------------
To unsubscribe, e-mail: lucene-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: lucene-dev-help@jakarta.apache.org


Mime
View raw message