lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Scott Ganyo <scott.ga...@eTapestry.com>
Subject RE: cvs commit: jakarta-lucene/src/java/org/apache/lucene/index F ieldsReader.java
Date Thu, 19 Sep 2002 18:47:57 GMT
Ack.  Well, that is Sun's idea of "standard Java style," which I rigorously
disagree with.  Also, given the amount of Java code that doesn't follow that
style, I would disagree that it is at all "standard."  Remember that package
names beginning with all caps like "COM and EDU" used to be Sun's "standard"
style, too, until they got the hint.  

Nevertheless, I'm willing to accept that you have defined it as "Lucene
standard style" and I do abide by it when developing Lucene...

Scott

(P.S. Sorry, I realize this is holy-war territory, but I couldn't resist.)

> -----Original Message-----
> From: Doug Cutting [mailto:cutting@lucene.com]
> Sent: Thursday, September 19, 2002 12:12 PM
> To: Lucene Developers List
> Subject: Re: cvs commit: 
> jakarta-lucene/src/java/org/apache/lucene/index
> FieldsReader.java
> 
> 
> Otis,
> 
> I really appreciate all of the work you do on Lucene.  
> However sometimes 
> I have to disagree.
> 
> otis@apache.org wrote:
> >   - Added FIXME/TODO tags about things to document.
> 
> While documentation in a package private class is nice, it is not an 
> absolute requirement.  So I don't think this warrants a FIXME comment.
> 
> >   -final class FieldsReader {
> >   +final class FieldsReader
> >   +{
> 
> You also re-indented the code and your indentation style violates 
> standard Java style.  In Java, opening braces go with the 
> previous line, 
> not on a line of their own:
> 
>    
> http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#15395
> 
> Doug
> 
> 
> --
> To unsubscribe, e-mail:   
<mailto:lucene-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:lucene-dev-help@jakarta.apache.org>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message