lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug Cutting <cutt...@lucene.com>
Subject Re: cvs commit: jakarta-lucene/src/java/org/apache/lucene/index FieldsReader.java
Date Thu, 19 Sep 2002 17:11:32 GMT
Otis,

I really appreciate all of the work you do on Lucene.  However sometimes 
I have to disagree.

otis@apache.org wrote:
>   - Added FIXME/TODO tags about things to document.

While documentation in a package private class is nice, it is not an 
absolute requirement.  So I don't think this warrants a FIXME comment.

>   -final class FieldsReader {
>   +final class FieldsReader
>   +{

You also re-indented the code and your indentation style violates 
standard Java style.  In Java, opening braces go with the previous line, 
not on a line of their own:

   http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#15395

Doug


--
To unsubscribe, e-mail:   <mailto:lucene-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:lucene-dev-help@jakarta.apache.org>


Mime
View raw message