lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Otis Gospodnetic <otis_gospodne...@yahoo.com>
Subject Re: Add ability to get list of terms from a query
Date Fri, 15 Feb 2002 20:33:54 GMT
Peter,

Looks fine, these are only new methods and some accessor modifier
changes, so it shouldn't break any existing code.
I'm reading the PDF (nicely done!) now, but this looks good and
harmless, so +1.
Yummy.

Otis



--- Peter Carlson <carlson@bookandhammer.com> wrote:
> Hi All,
> I didn't get any feedback + or - on making these changes.
> I'll make the changes if people think it's a good idea.
> The changes essentially provide public methods to get the query or
> the term
> from the query.
> 
> Thanks
> 
> --Peter
> 
> On 2/7/02 12:41 PM, "carlson@bookandhammer.com"
> <carlson@bookandhammer.com>
> wrote:
> 
> > Hi,
> > 
> > I just added the Highlight terms functionality by Maik Schreiber to
> the
> > contributions section.
> > This code essentially gets all the terms for a given query, and
> then
> > provides an interface to highlight the text.
> > 
> > In order to provide this functionality he had to make some changes
> to
> > the core Lucene code.
> > 
> > I am suggesting providing the a query.getTerms() method. After
> review
> > and Maik approval, we might even want to use his code.
> > 
> > I would suggest making these changes after 1.2 is released.
> > 
> > To check out his code and PDF describing the changes, go to
> > http://www.iq-computing.de/lucene/highlight.htm
> > 
> > Please provide feedback.
> > 
> > Thanks
> > 
> > --Peter
> > 
> > ----LIST OF SUGGESTED CHANGES----
> > He documented it very well. Here are the list of changes.
> > 
> > org.apache.lucene.search.BooleanQuery - add the following method:
> > public BooleanClause[] getClauses()
> > {
> > return (BooleanClause[]) clauses.toArray(new BooleanClause[0]);
> > }
> > 
> > org.apache.lucene.search.MultiTermQuery - mark getQuery() public
> > 
> > org.apache.lucene.search.PhraseQuery - add the following method:
> > public Term[] getTerms()
> > {
> > return (Term[]) terms.toArray(new Term[0]);
> > }
> > 
> > org.apache.lucene.search.PrefixQuery - mark getQuery() public
> > 
> > org.apache.lucene.search.RangeQuery - mark getQuery() public
> > 
> > org.apache.lucene.search.TermQuery - add the following method:
> > public Term getTerm()
> > {
> > return term;
> > }



__________________________________________________
Do You Yahoo!?
Got something to say? Say it better with Yahoo! Video Mail 
http://mail.yahoo.com

--
To unsubscribe, e-mail:   <mailto:lucene-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:lucene-dev-help@jakarta.apache.org>


Mime
View raw message