lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <li...@ehatchersolutions.com>
Subject Re: cvs commit: jakarta-lucene build.xml
Date Wed, 27 Feb 2002 03:45:25 GMT
Agreed.  I would say that this is a good argument for getting rid of
build.properties.sample altogether.  Its not really needed, and anyone
wanting to tweak anything would likely have the know-how to figure out which
property they wanted to override by just looking at the top of build.xml.

I don't disapprove of the way you recommend.  I think we can just chalk it
up to a matter of preference.

There are many projects that follow the build.properties.sample pattern
(Slide, Cactus, Commons, Struts, at least on my local perhaps slightly
outdated codebases).

I actually prefer no build.properties.sample.

My argument against default.properties is that lazy folks would just edit
properties there rather than figuring out that they could override them by
creating a new file.  A developer is much less likely to touch build.xml,
and would quickly (with a little bit of Ant know-how) see the override files
available.

    Erik

----- Original Message -----
From: "Jon Scott Stevens" <jon@latchkey.com>
To: "Lucene Developers List" <lucene-dev@jakarta.apache.org>
Sent: Tuesday, February 26, 2002 9:37 PM
Subject: Re: cvs commit: jakarta-lucene build.xml


> If you have the properties both in build.properties.sample and build.xml,
> then it is two places that you have to maintain them in.
>
> -jon
>
> on 2/26/02 6:02 PM, "Erik Hatcher" <lists@ehatchersolutions.com> wrote:
>
> > They would not have to rename files to make things work... all the
> > properties got embedded into build.xml, so therefore no external files
are
> > needed with the default config.
> >
> > To customize is when you'd copy build.properties.sample, or hand create
your
> > own tweaking the properties you wanted to override.
> >
> > I prefer this because it keeps all defauilt build info inside build.xml
> > rather than there being two files necessary.
> >
> >   Erik
> >
> > ----- Original Message -----
> > From: "Jon Scott Stevens" <jon@latchkey.com>
> > To: "Lucene Developers List" <lucene-dev@jakarta.apache.org>
> > Sent: Tuesday, February 26, 2002 8:19 PM
> > Subject: Re: cvs commit: jakarta-lucene build.xml
> >
> >
> >> on 2/26/02 5:10 PM, "otis@apache.org" <otis@apache.org> wrote:
> >>
> >>> - Moved properties from build.properties in here. build.properties
> > should be
> >>>   removed and replaced by build.properties.sample.
> >>
> >> -1.
> >>
> >> A better way to deal with this is to follow what Scarab and other
projects
> >> do which is to do this:
> >>
> >>     <!-- Give user a chance to override without editing this file
> >>         (and without typing -D each time it compiles it -->
> >>     <property file="${user.home}/lucene.build.properties" />
> >>     <property file="${user.home}/build.properties" />
> >>     <property file="${basedir}/build.properties" />
> >>     <property file="${basedir}/default.properties" />
> >>
> >> First, rename build.properties to default.properties
> >>
> >> Next, a developer can create one or more of the following files:
> >>
> >> ~/build.properties
> >> ~/lucene.build.properties
> >> lucene/build.properties
> >>
> >> That way, developers don't need to rename files in order to make things
> > work
> >> and the 'default' properties don't clutter up the build.xml file.
> >>
> >> Thanks,
> >>
> >> -jon
> >>
> >>
> >> --
> >> To unsubscribe, e-mail:
> > <mailto:lucene-dev-unsubscribe@jakarta.apache.org>
> >> For additional commands, e-mail:
> > <mailto:lucene-dev-help@jakarta.apache.org>
> >>
> >>
> >
> >
> > --
> > To unsubscribe, e-mail:
<mailto:lucene-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
<mailto:lucene-dev-help@jakarta.apache.org>
>
> --
> Standard rules apply: Ask any questions, and you get the job. ;-)
>
>
> --
> To unsubscribe, e-mail:
<mailto:lucene-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
<mailto:lucene-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:lucene-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:lucene-dev-help@jakarta.apache.org>


Mime
View raw message