Return-Path: Delivered-To: apmail-jakarta-lucene-dev-archive@apache.org Received: (qmail 28678 invoked from network); 24 Jan 2002 19:57:26 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 24 Jan 2002 19:57:26 -0000 Received: (qmail 11229 invoked by uid 97); 24 Jan 2002 19:56:51 -0000 Delivered-To: qmlist-jakarta-archive-lucene-dev@jakarta.apache.org Received: (qmail 11214 invoked by uid 97); 24 Jan 2002 19:56:50 -0000 Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Lucene Developers List" Reply-To: "Lucene Developers List" Delivered-To: mailing list lucene-dev@jakarta.apache.org Received: (qmail 11198 invoked from network); 24 Jan 2002 19:56:49 -0000 Subject: RE: first draft From: "Andrew C. Oliver" To: 'Lucene Developers List' In-Reply-To: <4BC270C6AB8AD411AD0B00B0D0493DF0EE7E7F@mail.grandcentral.com> References: <4BC270C6AB8AD411AD0B00B0D0493DF0EE7E7F@mail.grandcentral.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Evolution/1.0.0.99+cvs.2001.12.18.08.57 (Preview Release) Date: 24 Jan 2002 14:47:46 -0500 Message-Id: <1011901666.5120.2413.camel@linux2.superlinksoftware.com> Mime-Version: 1.0 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Thu, 2002-01-24 at 12:01, Doug Cutting wrote: > Wow, this looks great! > Thanks! I try. > Some quick comments: > Thanks for the quick response. > 1. I'm not sure we need to tell folks how to build Lucene here. Shouldn't > they download a compiled release and just use the jar file there? The demo > classes are also provided pre-compiled. So ant and javacc should not be > required for the demos. Of course, once you start changing things you'll > need ant, but you shouldn't need javacc nor should you need to recompile > Lucene itself. Now that JavaCC has been removed from Lucene's lib directory > (for legal reasons) this is more important. > Would the demos be pre-compiled in the distribution? The point was to make sure the user had the demos built. If this would be the case then it would be great to rip that out, its certainly more advanced then I'd like to cover in the "Getting Started" guide. > 2. I'd remove the mention of merge factor. We should also probably remove > this from the demo code. It's there as a relic of my use of that class for > testing and benchmarking, but most folks should probably just go with the > default--especially in a HelloWorld type example. > +1 > 3. Should we upgrade the examples to StandardAnalyzer from StopAnalyzer? > One of the most common complaints is that Lucene doesn't index numbers: > that's because most folks start with the demo code which is based on > LetterTokenizer and throws out numbers. > :-) I just learned something new. +1. Definitely, I'll upgrade the examples and the guide. > 4. Packages: Pre-Apache the example code was in the "demo" package. With > the move to Apache it was put in org.apache.lucene. Should it instead go in > a sub-package? > Please complete my understanding. Did I mention the "demo" package? Currently there are two cvs locations under src: demo and java The demos are in org/apache/lucene, but the parent directory is "demo". Are you proposing both sources and demos be moved under "java" and demos be under org.apache.lucene.demo for instance? I don't have a particular strong opinion on this but it seems to me the demos are an "optional" package that one would not necessarily want distributed in a production application (such as would be the case with inclusion in the main jar file). I think moving forward some demos may be promoted to a more "application" or utility status. Just my opinion. As for packaging it in org.apache.lucene.demo in addition to keeping it in a separate jar (and hence under demo instead of java), I think that would be a good idea. Am I following you? Would you like me to make this change? > Anyway, none of these are a big deal. Overall, Bravo! +1. > On the contrary, these are very helpful. I'll make the adjustments promptly. Thanks, Andy > Doug > > -- > To unsubscribe, e-mail: > For additional commands, e-mail: > -- www.superlinksoftware.com www.sourceforge.net/projects/poi - port of Excel format to java http://developer.java.sun.com/developer/bugParade/bugs/4487555.html - fix java generics! The avalanche has already started. It is too late for the pebbles to vote. -Ambassador Kosh -- To unsubscribe, e-mail: For additional commands, e-mail: