Return-Path: <m.vanwijland@quicknet.nl>
Mailing-List: contact lucene-dev-help@jakarta.apache.org; run by ezmlm
Delivered-To: mailing list lucene-dev@jakarta.apache.org
Received: (qmail 84622 invoked from network); 10 Oct 2001 22:23:25 -0000
Received: from unknown (HELO snapper-qfe0) (195.66.15.141)
  by daedalus.apache.org with SMTP; 10 Oct 2001 22:23:25 -0000
Received: from qn-212-58-175-209.quicknet.nl ([212.58.175.209]:64948 "HELO
        orca") by snapper.soneraplaza.nl with SMTP id <S220338AbRJJWXG>;
	Thu, 11 Oct 2001 00:23:06 +0200
Message-ID: <028301c151da$07544c50$0401a8c0@orca>
From: "Maurits van Wijland" <m.vanwijland@quicknet.nl>
To: <lucene-dev@jakarta.apache.org>
References: <4BC270C6AB8AD411AD0B00B0D0493DF0EE7C57@mail.grandcentral.com>
Subject: Re: Dutch Stemmer
Date: Thu, 11 Oct 2001 00:22:06 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4133.2400
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

Doug,

I will add comments to the code and reduce the number of public classes.

Maurits.


----- Original Message -----
From: "Doug Cutting" <DCutting@grandcentral.com>
To: <lucene-dev@jakarta.apache.org>
Sent: Wednesday, October 10, 2001 7:37 PM
Subject: RE: Dutch Stemmer


> This looks good.  It is low-risk, since it changes no existing classes,
> adding new classes in a new package.  It looks as though you've
implemented
> the right things (a stemming filter, and an analyzer that plugs this
> together with a stop list and tokenizer).  I don't speak Dutch, so I
cannot
> assess the quality of these.
>
> My concerns before this is checked in are that:
>   1. It compiles.  I have not tested this yet, and we don't want to break
> the build.
>   2. More Javadoc is added.  My rule of thumb is that there should be no
> empty boxes in the generated javadoc, i.e., every publicly visible class,
> method and field must be documented.  Also, every package should have a
> package.html with at least a one-line description of what is in the
package.
>   3. Fewer classes and methods are public.  Do the Rule, RuleVector and
> DutchStemmer classes need to be public?  Probably little more than the
core
> classes (DutchStemFilter DutchAnalyzer) need to be public.
>
> Doug
>
> > -----Original Message-----
> > From: Maurits van Wijland [mailto:m.vanwijland@quicknet.nl]
> > Sent: Wednesday, October 10, 2001 12:48 AM
> > To: lucene-dev@jakarta.apache.org
> > Cc: joanne.sproston@teamware.co.uk; Doug Cutting
> > Subject: Dutch Stemmer
> >
> >
> > Doug,
> >
> > Here is my first version of the dutch stemmer.
> > Doug could you have a look at this?
> >
> > kind regards,
> >
> > Maurits
> >
> >
> >
>