lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gerlowsk...@apache.org
Subject [lucene-solr] branch jira/solr-13890 updated: SOLR-13890: Address review commends, round 4
Date Fri, 10 Jan 2020 17:59:56 GMT
This is an automated email from the ASF dual-hosted git repository.

gerlowskija pushed a commit to branch jira/solr-13890
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/jira/solr-13890 by this push:
     new 9c676e8  SOLR-13890: Address review commends, round 4
9c676e8 is described below

commit 9c676e831c3a118966e3a022074560995d3c1f9f
Author: Jason Gerlowski <gerlowskija@apache.org>
AuthorDate: Fri Jan 10 12:58:15 2020 -0500

    SOLR-13890: Address review commends, round 4
---
 solr/CHANGES.txt                                                  | 2 +-
 solr/core/src/java/org/apache/solr/search/TermsQParserPlugin.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 20b9015..b813128 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -194,7 +194,7 @@ Improvements
 * SOLR-13890: Add "top-level" DV implementation for {!terms} queries.  This approach tends
to be more efficient for
   queries with very large numbers of terms.  The new implementation is used by default for
method=docValuesTermsFilter
   terms queries that are searching 500 or more terms.  Users wishing to ignore this heuristic
can choose the
-  docValuesTermsFilterTopLevel or docValuesTermsFilterPerSegment methods directly.
+  docValuesTermsFilterTopLevel or docValuesTermsFilterPerSegment methods directly. (Jason
Gerlowski, Joel Bernstein, David Smiley)
 
 Optimizations
 ---------------------
diff --git a/solr/core/src/java/org/apache/solr/search/TermsQParserPlugin.java b/solr/core/src/java/org/apache/solr/search/TermsQParserPlugin.java
index 874d720..1d92b7c 100644
--- a/solr/core/src/java/org/apache/solr/search/TermsQParserPlugin.java
+++ b/solr/core/src/java/org/apache/solr/search/TermsQParserPlugin.java
@@ -92,7 +92,7 @@ public class TermsQParserPlugin extends QParserPlugin {
       @Override
       Query makeFilter(String fname, BytesRef[] byteRefs) {
         // TODO Further tune this heuristic number
-        return disableCacheByDefault((byteRefs.length > 700) ? new TopLevelDocValuesTermsQuery(fname,
byteRefs) : new DocValuesTermsQuery(fname, byteRefs));
+        return (byteRefs.length > 700) ? docValuesTermsFilterTopLevel.makeFilter(fname,
byteRefs) : docValuesTermsFilterPerSegment.makeFilter(fname, byteRefs);
       }
     },
     docValuesTermsFilterTopLevel {


Mime
View raw message