lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hoss...@apache.org
Subject [lucene-solr] branch branch_8x updated: SOLR-13747: New TestSSLTestConfig.testFailIfUserRunsTestsWithJVMThatHasKnownSSLBugs() to give people running tests more visibility if/when they use a known-buggy JVM causing most SSL tests to silently SKIP
Date Thu, 26 Sep 2019 22:04:28 GMT
This is an automated email from the ASF dual-hosted git repository.

hossman pushed a commit to branch branch_8x
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/branch_8x by this push:
     new e979255  SOLR-13747: New TestSSLTestConfig.testFailIfUserRunsTestsWithJVMThatHasKnownSSLBugs()
to give people running tests more visibility if/when they use a known-buggy JVM causing most
SSL tests to silently SKIP
e979255 is described below

commit e979255ca75bc554a75daeda523bb0b60ade39f2
Author: Chris Hostetter <hossman@apache.org>
AuthorDate: Thu Sep 26 14:12:20 2019 -0700

    SOLR-13747: New TestSSLTestConfig.testFailIfUserRunsTestsWithJVMThatHasKnownSSLBugs()
to give people running tests more visibility if/when they use a known-buggy JVM causing most
SSL tests to silently SKIP
    
    (cherry picked from commit ec9780c8aad7ffbf394d4cbefa772c6ba61650d0)
---
 solr/CHANGES.txt                                        |  3 +++
 .../test/org/apache/solr/util/TestSSLTestConfig.java    | 17 +++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index c012657..9af0d91 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -205,6 +205,9 @@ Other Changes
 
 * SOLR-11492: Clean up /solr/cloud-dev scripts and provide a single well documented script
(Gus Heck, Robert Bunch)
 
+* SOLR-13747: New TestSSLTestConfig.testFailIfUserRunsTestsWithJVMThatHasKnownSSLBugs() to
give people running
+  tests more visibility if/when they use a known-buggy JVM causing most SSL tests to silently
SKIP. (hossman)
+
 ==================  8.2.0 ==================
 
 Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.
diff --git a/solr/test-framework/src/test/org/apache/solr/util/TestSSLTestConfig.java b/solr/test-framework/src/test/org/apache/solr/util/TestSSLTestConfig.java
index 4e39954..ed23459 100644
--- a/solr/test-framework/src/test/org/apache/solr/util/TestSSLTestConfig.java
+++ b/solr/test-framework/src/test/org/apache/solr/util/TestSSLTestConfig.java
@@ -20,6 +20,8 @@ package org.apache.solr.util;
 import java.util.Arrays;
 import java.util.List;
 
+import org.apache.lucene.util.Constants;
+
 import org.apache.solr.SolrTestCase;
 
 public class TestSSLTestConfig extends SolrTestCase {
@@ -84,4 +86,19 @@ public class TestSSLTestConfig extends SolrTestCase {
     
   }
 
+  public void testFailIfUserRunsTestsWithJVMThatHasKnownSSLBugs() {
+    // NOTE: If there is some future JVM version, where all available "ea" builds are known
to be buggy,
+    // but we still want to be able to use for running tests (ie: via jenkins) to look for
*other* bugs,
+    // then those -ea versions can be "white listed" here...
+
+    try {
+      SSLTestConfig.assumeSslIsSafeToTest();
+    } catch (org.junit.AssumptionViolatedException ave) {
+      fail("Current JVM (" + Constants.JVM_NAME + " / " + Constants.JVM_VERSION +
+           ") is known to have SSL Bugs.  Other tests that (explicitly or via randomization)
" +
+           " use SSL will be SKIPed");
+    }
+  }
+
+  
 }


Mime
View raw message