From commits-return-108562-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Tue Jun 4 20:59:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B12C218064D for ; Tue, 4 Jun 2019 22:59:52 +0200 (CEST) Received: (qmail 62399 invoked by uid 500); 4 Jun 2019 20:52:31 -0000 Mailing-List: contact commits-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list commits@lucene.apache.org Received: (qmail 62358 invoked by uid 99); 4 Jun 2019 20:52:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2019 20:52:31 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 119CF8AA96; Tue, 4 Jun 2019 20:52:31 +0000 (UTC) Date: Tue, 04 Jun 2019 20:52:30 +0000 To: "commits@lucene.apache.org" Subject: [lucene-solr] branch master updated: Fix TestSort.testRandomFieldNameSorts typo that ccaused very sporadic but reproducible failures MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <155968155094.29387.11666967630134648113@gitbox.apache.org> From: hossman@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: lucene-solr X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: a8fc0693957b12e7de8a07140848f0d863eee645 X-Git-Newrev: 92cf9d8758285352a6bd3a959988f9b72ecdf8f0 X-Git-Rev: 92cf9d8758285352a6bd3a959988f9b72ecdf8f0 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. hossman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/lucene-solr.git The following commit(s) were added to refs/heads/master by this push: new 92cf9d8 Fix TestSort.testRandomFieldNameSorts typo that ccaused very sporadic but reproducible failures 92cf9d8 is described below commit 92cf9d8758285352a6bd3a959988f9b72ecdf8f0 Author: Chris Hostetter AuthorDate: Tue Jun 4 13:49:57 2019 -0700 Fix TestSort.testRandomFieldNameSorts typo that ccaused very sporadic but reproducible failures --- solr/core/src/test/org/apache/solr/search/TestSort.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/solr/core/src/test/org/apache/solr/search/TestSort.java b/solr/core/src/test/org/apache/solr/search/TestSort.java index 0d276dc..00d3c5f 100644 --- a/solr/core/src/test/org/apache/solr/search/TestSort.java +++ b/solr/core/src/test/org/apache/solr/search/TestSort.java @@ -111,8 +111,8 @@ public class TestSort extends SolrTestCaseJ4 { names[j] = TestUtil.randomRealisticUnicodeString(r, 1, 100); // munge anything that might make this a function - names[j] = names[j].replaceFirst("\\{","\\{\\{"); - names[j] = names[j].replaceFirst("\\(","\\(\\("); + names[j] = names[j].replaceFirst("\\{","\\}\\{"); + names[j] = names[j].replaceFirst("\\(","\\)\\("); names[j] = names[j].replaceFirst("(\\\"|\\')","$1$1z"); names[j] = names[j].replaceFirst("(\\d)","$1x"); @@ -162,7 +162,8 @@ public class TestSort extends SolrTestCaseJ4 { assertEquals("sorts["+j+"] is (unexpectedly) type doc : " + input, "_docid_", names[j]); } else if (Type.CUSTOM.equals(type) || Type.REWRITEABLE.equals(type)) { - + log.error("names[{}] : {}", j, names[j]); + log.error("sorts[{}] : {}", j, sorts[j]); fail("sorts["+j+"] resulted in a '" + type.toString() + "', either sort parsing code is broken, or func/query " + "semantics have gotten broader and munging in this test "