lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tflo...@apache.org
Subject [lucene-solr] branch master updated: Removed some unused variables from DistributedUpdateProcessor
Date Wed, 06 Feb 2019 19:32:04 GMT
This is an automated email from the ASF dual-hosted git repository.

tflobbe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/master by this push:
     new 0add3bb  Removed some unused variables from DistributedUpdateProcessor
0add3bb is described below

commit 0add3bb0ac6d7c3a2bd1ad8dde57f8b24f8bb121
Author: Tomas Fernandez Lobbe <tflobbe@gmail.com>
AuthorDate: Fri Jan 25 18:17:32 2019 -0800

    Removed some unused variables from DistributedUpdateProcessor
---
 .../apache/solr/update/processor/DistributedUpdateProcessor.java | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
b/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
index 0b125a1..c8ddeb9 100644
--- a/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
+++ b/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
@@ -31,9 +31,6 @@ import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Set;
-import java.util.concurrent.CompletionService;
-import java.util.concurrent.ExecutorCompletionService;
-import java.util.concurrent.Future;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.locks.ReentrantLock;
 
@@ -63,7 +60,6 @@ import org.apache.solr.common.cloud.Replica;
 import org.apache.solr.common.cloud.RoutingRule;
 import org.apache.solr.common.cloud.Slice;
 import org.apache.solr.common.cloud.Slice.State;
-import org.apache.solr.common.cloud.SolrZkClient;
 import org.apache.solr.common.cloud.ZkCoreNodeProps;
 import org.apache.solr.common.cloud.ZkStateReader;
 import org.apache.solr.common.cloud.ZooKeeperException;
@@ -561,7 +557,6 @@ public class DistributedUpdateProcessor extends UpdateRequestProcessor
{
                           ZkStateReader.COLLECTION_PROP, collection,
                           ZkStateReader.SHARD_ID_PROP, myShardId,
                           "routeKey", routeKey + "!");
-                      SolrZkClient zkClient = zkController.getZkClient();
                       zkController.getOverseer().offerStateUpdate(Utils.toJSON(map));
                     } catch (KeeperException e) {
                       log.warn("Exception while removing routing rule for route key: " +
routeKey, e);
@@ -1097,7 +1092,7 @@ public class DistributedUpdateProcessor extends UpdateRequestProcessor
{
               versionOnUpdate = 0;
             }
 
-            boolean updated = getUpdatedDocument(cmd, versionOnUpdate);
+            getUpdatedDocument(cmd, versionOnUpdate);
 
             // leaders can also be in buffering state during "migrate" API call, see SOLR-5308
             if (forwardedFromCollection && ulog.getState() != UpdateLog.State.ACTIVE
@@ -1955,8 +1950,6 @@ public class DistributedUpdateProcessor extends UpdateRequestProcessor
{
           && node.getNodeProps().getCoreName().equals(req.getCore().getName()));
     }
     
-    CompletionService<Exception> completionService = new ExecutorCompletionService<>(req.getCore().getCoreContainer().getUpdateShardHandler().getUpdateExecutor());
-    Set<Future<Exception>> pending = new HashSet<>();
     if (!zkEnabled || (!isLeader && req.getParams().get(COMMIT_END_POINT, "").equals("replicas")))
{
       if (replicaType == Replica.Type.TLOG) {
 


Mime
View raw message