From commits-return-104327-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Tue Oct 23 01:34:57 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DFDDA18077D for ; Tue, 23 Oct 2018 01:34:55 +0200 (CEST) Received: (qmail 44286 invoked by uid 500); 22 Oct 2018 23:34:48 -0000 Mailing-List: contact commits-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list commits@lucene.apache.org Received: (qmail 42865 invoked by uid 99); 22 Oct 2018 23:34:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2018 23:34:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id AB512E11D9; Mon, 22 Oct 2018 23:34:46 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ctargett@apache.org To: commits@lucene.apache.org Date: Mon, 22 Oct 2018 23:35:27 -0000 Message-Id: <753ac1c6f1b9454fb200d2a31a20551c@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [42/50] [abbrv] lucene-solr:jira/solr-12746: LUCENE-8533: Fix Javadocs of DataInput#readVInt(): Negative numbers are supported, but should be avoided. LUCENE-8533: Fix Javadocs of DataInput#readVInt(): Negative numbers are supported, but should be avoided. Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/0f26cb99 Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/0f26cb99 Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/0f26cb99 Branch: refs/heads/jira/solr-12746 Commit: 0f26cb996109b6458fe14c9706ca7076f9987ca8 Parents: 4c02ba6 Author: Uwe Schindler Authored: Thu Oct 18 12:36:16 2018 +0200 Committer: Cassandra Targett Committed: Sun Oct 21 15:46:48 2018 -0500 ---------------------------------------------------------------------- lucene/CHANGES.txt | 3 +++ lucene/core/src/java/org/apache/lucene/store/DataInput.java | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/0f26cb99/lucene/CHANGES.txt ---------------------------------------------------------------------- diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt index 7a181bd..50b1cf3 100644 --- a/lucene/CHANGES.txt +++ b/lucene/CHANGES.txt @@ -208,6 +208,9 @@ Other: * LUCENE-8523: Correct typo in JapaneseNumberFilterFactory javadocs (Ankush Jhalani via Alan Woodward) +* LUCENE-8533: Fix Javadocs of DataInput#readVInt(): Negative numbers are + supported, but should be avoided. (Vladimir Dolzhenko via Uwe Schindler) + ======================= Lucene 7.5.1 ======================= Bug Fixes: http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/0f26cb99/lucene/core/src/java/org/apache/lucene/store/DataInput.java ---------------------------------------------------------------------- diff --git a/lucene/core/src/java/org/apache/lucene/store/DataInput.java b/lucene/core/src/java/org/apache/lucene/store/DataInput.java index d834995..2514b84 100644 --- a/lucene/core/src/java/org/apache/lucene/store/DataInput.java +++ b/lucene/core/src/java/org/apache/lucene/store/DataInput.java @@ -103,8 +103,8 @@ public abstract class DataInput implements Cloneable { } /** Reads an int stored in variable-length format. Reads between one and - * five bytes. Smaller values take fewer bytes. Negative numbers are not - * supported. + * five bytes. Smaller values take fewer bytes. Negative numbers are + * supported, but should be avoided. *

* The format is described further in {@link DataOutput#writeVInt(int)}. *