From commits-return-101438-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Thu Jun 7 14:03:21 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0BAF1180663 for ; Thu, 7 Jun 2018 14:03:20 +0200 (CEST) Received: (qmail 79280 invoked by uid 500); 7 Jun 2018 12:03:20 -0000 Mailing-List: contact commits-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list commits@lucene.apache.org Received: (qmail 79271 invoked by uid 99); 7 Jun 2018 12:03:20 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2018 12:03:20 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id EAD09E04BC; Thu, 7 Jun 2018 12:03:19 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: romseygeek@apache.org To: commits@lucene.apache.org Date: Thu, 07 Jun 2018 12:03:19 -0000 Message-Id: <085e5eab8f174406913a3fb50e961bfa@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/2] lucene-solr:branch_7x: LUCENE-8273: Don't wrap ShingleFilter in conditions in testRandomChains Repository: lucene-solr Updated Branches: refs/heads/branch_7x b283f7662 -> dfb679a93 refs/heads/master a82c9cfcf -> a4fa16896 LUCENE-8273: Don't wrap ShingleFilter in conditions in testRandomChains Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/dfb679a9 Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/dfb679a9 Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/dfb679a9 Branch: refs/heads/branch_7x Commit: dfb679a93cc9aae2620e7ce110c9515181bd17c6 Parents: b283f76 Author: Alan Woodward Authored: Thu Jun 7 12:53:43 2018 +0100 Committer: Alan Woodward Committed: Thu Jun 7 12:53:58 2018 +0100 ---------------------------------------------------------------------- .../test/org/apache/lucene/analysis/core/TestRandomChains.java | 5 +++++ 1 file changed, 5 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/dfb679a9/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java ---------------------------------------------------------------------- diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java index d94b396..fd6f4b5 100644 --- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java +++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java @@ -88,6 +88,7 @@ import org.apache.lucene.analysis.path.PathHierarchyTokenizer; import org.apache.lucene.analysis.path.ReversePathHierarchyTokenizer; import org.apache.lucene.analysis.payloads.IdentityEncoder; import org.apache.lucene.analysis.payloads.PayloadEncoder; +import org.apache.lucene.analysis.shingle.ShingleFilter; import org.apache.lucene.analysis.snowball.TestSnowball; import org.apache.lucene.analysis.standard.StandardTokenizer; import org.apache.lucene.analysis.synonym.SynonymMap; @@ -124,6 +125,10 @@ public class TestRandomChains extends BaseTokenStreamTestCase { avoidConditionals.add(FingerprintFilter.class); avoidConditionals.add(MinHashFilter.class); avoidConditionals.add(ConcatenateGraphFilter.class); + // ShingleFilter doesn't handle input graphs correctly, so wrapping it in a condition can + // expose inconsistent offsets + // https://issues.apache.org/jira/browse/LUCENE-4170 + avoidConditionals.add(ShingleFilter.class); } private static final Map,Predicate> brokenConstructors = new HashMap<>();