lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From romseyg...@apache.org
Subject [2/2] lucene-solr:master: LUCENE-8273: Don't wrap ShingleFilter in conditions in testRandomChains
Date Thu, 07 Jun 2018 12:03:20 GMT
LUCENE-8273: Don't wrap ShingleFilter in conditions in testRandomChains


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/a4fa1689
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/a4fa1689
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/a4fa1689

Branch: refs/heads/master
Commit: a4fa16896225e08b72bf64fba97a216bb6a83fbb
Parents: a82c9cf
Author: Alan Woodward <romseygeek@apache.org>
Authored: Thu Jun 7 12:53:43 2018 +0100
Committer: Alan Woodward <romseygeek@apache.org>
Committed: Thu Jun 7 12:54:10 2018 +0100

----------------------------------------------------------------------
 .../test/org/apache/lucene/analysis/core/TestRandomChains.java  | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/a4fa1689/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
----------------------------------------------------------------------
diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
b/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
index d94b396..fd6f4b5 100644
--- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
+++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
@@ -88,6 +88,7 @@ import org.apache.lucene.analysis.path.PathHierarchyTokenizer;
 import org.apache.lucene.analysis.path.ReversePathHierarchyTokenizer;
 import org.apache.lucene.analysis.payloads.IdentityEncoder;
 import org.apache.lucene.analysis.payloads.PayloadEncoder;
+import org.apache.lucene.analysis.shingle.ShingleFilter;
 import org.apache.lucene.analysis.snowball.TestSnowball;
 import org.apache.lucene.analysis.standard.StandardTokenizer;
 import org.apache.lucene.analysis.synonym.SynonymMap;
@@ -124,6 +125,10 @@ public class TestRandomChains extends BaseTokenStreamTestCase {
     avoidConditionals.add(FingerprintFilter.class);
     avoidConditionals.add(MinHashFilter.class);
     avoidConditionals.add(ConcatenateGraphFilter.class);
+    // ShingleFilter doesn't handle input graphs correctly, so wrapping it in a condition
can
+    // expose inconsistent offsets
+    // https://issues.apache.org/jira/browse/LUCENE-4170
+    avoidConditionals.add(ShingleFilter.class);
   }
 
   private static final Map<Constructor<?>,Predicate<Object[]>> brokenConstructors
= new HashMap<>();


Mime
View raw message