lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kwri...@apache.org
Subject lucene-solr:master: LUCENE-8220: need a continue, not a break
Date Sun, 25 Mar 2018 07:59:07 GMT
Repository: lucene-solr
Updated Branches:
  refs/heads/master d49ba5c33 -> 9e5468adc


LUCENE-8220: need a continue, not a break


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/9e5468ad
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/9e5468ad
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/9e5468ad

Branch: refs/heads/master
Commit: 9e5468adcd156f6ff2592d8607afd83f7303a860
Parents: d49ba5c
Author: Karl Wright <DaddyWri@gmail.com>
Authored: Sun Mar 25 03:58:51 2018 -0400
Committer: Karl Wright <DaddyWri@gmail.com>
Committed: Sun Mar 25 03:58:51 2018 -0400

----------------------------------------------------------------------
 .../java/org/apache/lucene/spatial3d/geom/GeoPolygonFactory.java   | 2 +-
 .../src/test/org/apache/lucene/spatial3d/geom/GeoPolygonTest.java  | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/9e5468ad/lucene/spatial3d/src/java/org/apache/lucene/spatial3d/geom/GeoPolygonFactory.java
----------------------------------------------------------------------
diff --git a/lucene/spatial3d/src/java/org/apache/lucene/spatial3d/geom/GeoPolygonFactory.java
b/lucene/spatial3d/src/java/org/apache/lucene/spatial3d/geom/GeoPolygonFactory.java
index 082d0d2..8ebebcf 100755
--- a/lucene/spatial3d/src/java/org/apache/lucene/spatial3d/geom/GeoPolygonFactory.java
+++ b/lucene/spatial3d/src/java/org/apache/lucene/spatial3d/geom/GeoPolygonFactory.java
@@ -912,7 +912,7 @@ public class GeoPolygonFactory {
           // to the end point of the edge.  We generate that as a triangle convex polygon,
and tile the two remaining pieces.
           if (Plane.arePointsCoplanar(checkEdge.startPoint, checkEdge.endPoint, thePoint))
{
             // Can't build this particular tile because of colinearity, so advance to another
that maybe we can build.
-            break;
+            continue;
           }
           final List<GeoPoint> thirdPartPoints = new ArrayList<>(3);
           final BitSet thirdPartInternal = new BitSet();

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/9e5468ad/lucene/spatial3d/src/test/org/apache/lucene/spatial3d/geom/GeoPolygonTest.java
----------------------------------------------------------------------
diff --git a/lucene/spatial3d/src/test/org/apache/lucene/spatial3d/geom/GeoPolygonTest.java
b/lucene/spatial3d/src/test/org/apache/lucene/spatial3d/geom/GeoPolygonTest.java
index c0806b3..a780bad 100755
--- a/lucene/spatial3d/src/test/org/apache/lucene/spatial3d/geom/GeoPolygonTest.java
+++ b/lucene/spatial3d/src/test/org/apache/lucene/spatial3d/geom/GeoPolygonTest.java
@@ -1127,6 +1127,8 @@ shape:
     assertTrue(polygon != null);
   }
 
+  @Test
+  @Ignore
   public void testCoplanarityConcave() throws Exception {
     //POLYGON((-52.18851 64.53777,-52.18853 64.53828,-52.18675 64.53829,-52.18676 64.53855,-52.18736
64.53855,-52.18737 64.53881,-52.18677 64.53881,-52.18683 64.54009,-52.18919 64.53981,-52.18916
64.53905,-52.19093 64.53878,-52.19148 64.53775,-52.18851 64.53777))
     List<GeoPoint> points = new ArrayList<>();


Mime
View raw message