lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a.@apache.org
Subject [25/50] lucene-solr:jira/solr-11458-2: LUCENE-8062: GlobalOrdinalsQuery is no longer eligible for caching
Date Mon, 04 Dec 2017 17:49:09 GMT
LUCENE-8062: GlobalOrdinalsQuery is no longer eligible for caching


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/a06e6856
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/a06e6856
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/a06e6856

Branch: refs/heads/jira/solr-11458-2
Commit: a06e685642a9615ad03816a1310db15ad752f0ca
Parents: 207e546
Author: Jim Ferenczi <jimczi@apache.org>
Authored: Tue Nov 28 14:56:28 2017 +0100
Committer: Jim Ferenczi <jimczi@apache.org>
Committed: Tue Nov 28 14:56:28 2017 +0100

----------------------------------------------------------------------
 lucene/CHANGES.txt                                              | 2 ++
 .../java/org/apache/lucene/search/join/GlobalOrdinalsQuery.java | 5 ++++-
 2 files changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/a06e6856/lucene/CHANGES.txt
----------------------------------------------------------------------
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 7df88fc..084d0dd 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -121,6 +121,8 @@ Optimizations
 * LUCENE-7994: Use int/int scatter map to gather facet counts when the
   number of hits is small relative to the number of unique facet labels
   (Dawid Weiss, Robert Muir, Mike McCandless)
+
+* LUCENE-8062: GlobalOrdinalsQuery is no longer eligible for caching. (Jim Ferenczi)
   
 Tests
 

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/a06e6856/lucene/join/src/java/org/apache/lucene/search/join/GlobalOrdinalsQuery.java
----------------------------------------------------------------------
diff --git a/lucene/join/src/java/org/apache/lucene/search/join/GlobalOrdinalsQuery.java b/lucene/join/src/java/org/apache/lucene/search/join/GlobalOrdinalsQuery.java
index 4b2d987..b1c0b91 100644
--- a/lucene/join/src/java/org/apache/lucene/search/join/GlobalOrdinalsQuery.java
+++ b/lucene/join/src/java/org/apache/lucene/search/join/GlobalOrdinalsQuery.java
@@ -156,7 +156,10 @@ final class GlobalOrdinalsQuery extends Query {
 
     @Override
     public boolean isCacheable(LeafReaderContext ctx) {
-      return DocValues.isCacheable(ctx, joinField);
+      // disable caching because this query relies on a top reader context
+      // and holds a bitset of matching ordinals that cannot be accounted in
+      // the memory used by the cache
+      return false;
     }
 
   }


Mime
View raw message