lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a.@apache.org
Subject [05/50] [abbrv] lucene-solr:jira/solr-11285-sim: SOLR-11713: Fixed CdcrUpdateLogTest.testSubReader() failure which was a test bug
Date Thu, 07 Dec 2017 12:44:59 GMT
SOLR-11713: Fixed CdcrUpdateLogTest.testSubReader() failure which was a test bug


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/2ed0f1b6
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/2ed0f1b6
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/2ed0f1b6

Branch: refs/heads/jira/solr-11285-sim
Commit: 2ed0f1b68e1d6d9dbb1141bb7032b8a0bc54ffa1
Parents: ae9cc72
Author: Varun Thacker <varun@apache.org>
Authored: Sun Dec 3 23:17:51 2017 -0800
Committer: Varun Thacker <varun@apache.org>
Committed: Sun Dec 3 23:17:51 2017 -0800

----------------------------------------------------------------------
 solr/CHANGES.txt                                                 | 2 ++
 solr/core/src/test/org/apache/solr/update/CdcrUpdateLogTest.java | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/2ed0f1b6/solr/CHANGES.txt
----------------------------------------------------------------------
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index e02e1cf..b20c589 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -223,6 +223,8 @@ Other Changes
 * SOLR-11291: Factor out abstract metrics/SolrCore[Container]Reporter classes.
   (Omar Abdelnabi, Christine Poerschke)
 
+* SOLR-11713: Fixed CdcrUpdateLogTest.testSubReader() failure which was a test bug (Varun
Thacker, Amrit Sarkar)
+
 ==================  7.1.0 ==================
 
 Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/2ed0f1b6/solr/core/src/test/org/apache/solr/update/CdcrUpdateLogTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/update/CdcrUpdateLogTest.java b/solr/core/src/test/org/apache/solr/update/CdcrUpdateLogTest.java
index b7409d1..002cfa5 100644
--- a/solr/core/src/test/org/apache/solr/update/CdcrUpdateLogTest.java
+++ b/solr/core/src/test/org/apache/solr/update/CdcrUpdateLogTest.java
@@ -580,8 +580,8 @@ public class CdcrUpdateLogTest extends SolrTestCaseJ4 {
     // After fast forward, the parent reader should be position on the doc15
     List o = (List) reader.next();
     assertNotNull(o);
-    assertTrue(o.get(2) instanceof SolrInputDocument);
-    assertEquals("15", ((SolrInputDocument) o.get(2)).getFieldValue("id"));
+    assertTrue("Expected SolrInputDocument but got" + o.toString() ,o.get(3) instanceof SolrInputDocument);
+    assertEquals("15", ((SolrInputDocument) o.get(3)).getFieldValue("id"));
 
     // Finish to read the second tlog, and start to read the third one
     for (int i = 0; i < 6; i++) {


Mime
View raw message