Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 88696200D29 for ; Wed, 20 Sep 2017 10:46:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 870EF1609E6; Wed, 20 Sep 2017 08:46:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C4CB51609E2 for ; Wed, 20 Sep 2017 10:46:21 +0200 (CEST) Received: (qmail 33431 invoked by uid 500); 20 Sep 2017 08:46:19 -0000 Mailing-List: contact commits-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list commits@lucene.apache.org Received: (qmail 33117 invoked by uid 99); 20 Sep 2017 08:46:19 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Sep 2017 08:46:19 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CEB1EF5830; Wed, 20 Sep 2017 08:46:17 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ab@apache.org To: commits@lucene.apache.org Date: Wed, 20 Sep 2017 08:46:30 -0000 Message-Id: <51793c3415ca4adea1412c0e311d753c@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [14/50] lucene-solr:jira/solr-11285: LUCENE-7963: Remove useless getAttribute() in DefaultIndexingChain that causes performance drop, introduced by LUCENE-7626 archived-at: Wed, 20 Sep 2017 08:46:22 -0000 LUCENE-7963: Remove useless getAttribute() in DefaultIndexingChain that causes performance drop, introduced by LUCENE-7626 Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/a5402f68 Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/a5402f68 Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/a5402f68 Branch: refs/heads/jira/solr-11285 Commit: a5402f68631768bae57d923613211128de077982 Parents: 5fee937 Author: Uwe Schindler Authored: Fri Sep 8 17:39:12 2017 +0200 Committer: Uwe Schindler Committed: Fri Sep 8 17:39:12 2017 +0200 ---------------------------------------------------------------------- lucene/CHANGES.txt | 4 ++++ .../src/java/org/apache/lucene/index/DefaultIndexingChain.java | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/a5402f68/lucene/CHANGES.txt ---------------------------------------------------------------------- diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt index 0dced28..a2fd223 100644 --- a/lucene/CHANGES.txt +++ b/lucene/CHANGES.txt @@ -200,6 +200,10 @@ Bug Fixes * LUCENE-7956: Fixed potential stack overflow error in ICUNormalizer2CharFilter. (Adrien Grand) +* LUCENE-7963: Remove useless getAttribute() in DefaultIndexingChain that + causes performance drop, introduced by LUCENE-7626. (Daniel Mitterdorfer + via Uwe Schindler) + Improvements * LUCENE-7489: Better storage of sparse doc-values fields with the default http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/a5402f68/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java ---------------------------------------------------------------------- diff --git a/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java b/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java index f2c3de1..fd24105 100644 --- a/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java +++ b/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java @@ -27,7 +27,6 @@ import java.util.Map; import java.util.Set; import org.apache.lucene.analysis.TokenStream; -import org.apache.lucene.analysis.tokenattributes.CharTermAttribute; import org.apache.lucene.codecs.DocValuesConsumer; import org.apache.lucene.codecs.DocValuesFormat; import org.apache.lucene.codecs.NormsConsumer; @@ -733,7 +732,6 @@ final class DefaultIndexingChain extends DocConsumer { stream.reset(); invertState.setAttributeSource(stream); termsHashPerField.start(field, first); - CharTermAttribute termAtt = tokenStream.getAttribute(CharTermAttribute.class); while (stream.incrementToken()) {