lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a.@apache.org
Subject [14/50] lucene-solr:jira/solr-11285: LUCENE-7963: Remove useless getAttribute() in DefaultIndexingChain that causes performance drop, introduced by LUCENE-7626
Date Wed, 20 Sep 2017 08:46:30 GMT
LUCENE-7963: Remove useless getAttribute() in DefaultIndexingChain that causes performance
drop, introduced by LUCENE-7626


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/a5402f68
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/a5402f68
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/a5402f68

Branch: refs/heads/jira/solr-11285
Commit: a5402f68631768bae57d923613211128de077982
Parents: 5fee937
Author: Uwe Schindler <uschindler@apache.org>
Authored: Fri Sep 8 17:39:12 2017 +0200
Committer: Uwe Schindler <uschindler@apache.org>
Committed: Fri Sep 8 17:39:12 2017 +0200

----------------------------------------------------------------------
 lucene/CHANGES.txt                                               | 4 ++++
 .../src/java/org/apache/lucene/index/DefaultIndexingChain.java   | 2 --
 2 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/a5402f68/lucene/CHANGES.txt
----------------------------------------------------------------------
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 0dced28..a2fd223 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -200,6 +200,10 @@ Bug Fixes
 * LUCENE-7956: Fixed potential stack overflow error in ICUNormalizer2CharFilter.
   (Adrien Grand)
 
+* LUCENE-7963: Remove useless getAttribute() in DefaultIndexingChain that
+  causes performance drop, introduced by LUCENE-7626.  (Daniel Mitterdorfer
+  via Uwe Schindler)
+
 Improvements
 
 * LUCENE-7489: Better storage of sparse doc-values fields with the default

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/a5402f68/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java b/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
index f2c3de1..fd24105 100644
--- a/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
+++ b/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
@@ -27,7 +27,6 @@ import java.util.Map;
 import java.util.Set;
 
 import org.apache.lucene.analysis.TokenStream;
-import org.apache.lucene.analysis.tokenattributes.CharTermAttribute;
 import org.apache.lucene.codecs.DocValuesConsumer;
 import org.apache.lucene.codecs.DocValuesFormat;
 import org.apache.lucene.codecs.NormsConsumer;
@@ -733,7 +732,6 @@ final class DefaultIndexingChain extends DocConsumer {
         stream.reset();
         invertState.setAttributeSource(stream);
         termsHashPerField.start(field, first);
-        CharTermAttribute termAtt = tokenStream.getAttribute(CharTermAttribute.class);
 
         while (stream.incrementToken()) {
 


Mime
View raw message