lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m..@apache.org
Subject lucene-solr:master: LUCENE-7810: Fix numeric join equals test failure.
Date Wed, 24 May 2017 07:51:33 GMT
Repository: lucene-solr
Updated Branches:
  refs/heads/master 8f4d72a7d -> 65bfa4877


LUCENE-7810: Fix numeric join equals test failure.

Numeric join equals isn't based on the index reader, but rather on the collected join values.
In a test failure during the second indexing round no new join values were indexed causing
the equals assertion to fail.


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/65bfa487
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/65bfa487
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/65bfa487

Branch: refs/heads/master
Commit: 65bfa48770b33242d80dcce946073cc5698da7b1
Parents: 8f4d72a
Author: Martijn van Groningen <martijn.v.groningen@gmail.com>
Authored: Wed May 24 09:50:23 2017 +0200
Committer: Martijn van Groningen <mvg@apache.org>
Committed: Wed May 24 09:50:36 2017 +0200

----------------------------------------------------------------------
 .../src/test/org/apache/lucene/search/join/TestJoinUtil.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/65bfa487/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java
----------------------------------------------------------------------
diff --git a/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java b/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java
index c95e144..49dd333 100644
--- a/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java
+++ b/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java
@@ -1141,7 +1141,7 @@ public class TestJoinUtil extends LuceneTestCase {
                   indexSearcher, scoreMode1)));
         }
 
-        for (int i = 0; i < 13; i++) {
+        for (int i = 14; i < 26; i++) {
           Document doc = new Document();
           doc.add(new TextField("id", "new_id" , Field.Store.NO));
           doc.add(new TextField("name", "name5", Field.Store.NO));
@@ -1159,7 +1159,7 @@ public class TestJoinUtil extends LuceneTestCase {
         }
         try (IndexReader r = w.getReader()) {
           IndexSearcher indexSearcher = new IndexSearcher(r);
-          assertFalse("Query shouldn't be equal, because different index readers ",
+          assertFalse("Query shouldn't be equal, because new join values have been indexed",
               x.equals(JoinUtil.createJoinQuery(joinField, multiValued, joinField,
                   Integer.class, new TermQuery(new Term("name", "name5")),
                   indexSearcher, scoreMode1)));


Mime
View raw message