lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cpoersc...@apache.org
Subject lucene-solr:jira/solr-6203: remove Sort setters in (Search|Top)GroupsFieldCommand.Builder (in favour of SortSpec setters)
Date Thu, 30 Mar 2017 17:38:20 GMT
Repository: lucene-solr
Updated Branches:
  refs/heads/jira/solr-6203 caed03da4 -> 92b76abdd


remove Sort setters in (Search|Top)GroupsFieldCommand.Builder (in favour of SortSpec setters)


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/92b76abd
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/92b76abd
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/92b76abd

Branch: refs/heads/jira/solr-6203
Commit: 92b76abdd2ec85d9d36c66922107f4efbe6bc0b4
Parents: caed03d
Author: Christine Poerschke <cpoerschke@apache.org>
Authored: Thu Mar 30 18:33:48 2017 +0100
Committer: Christine Poerschke <cpoerschke@apache.org>
Committed: Thu Mar 30 18:33:48 2017 +0100

----------------------------------------------------------------------
 .../command/SearchGroupsFieldCommand.java            |  7 -------
 .../distributed/command/TopGroupsFieldCommand.java   | 15 ---------------
 2 files changed, 22 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/92b76abd/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/SearchGroupsFieldCommand.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/SearchGroupsFieldCommand.java
b/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/SearchGroupsFieldCommand.java
index 35da60a..1021a34 100644
--- a/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/SearchGroupsFieldCommand.java
+++ b/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/SearchGroupsFieldCommand.java
@@ -52,13 +52,6 @@ public class SearchGroupsFieldCommand implements Command<SearchGroupsFieldComman
       return this;
     }
 
-    // We can't reconstruct a SortSpec from a Sort.
-     @Deprecated  // JTODO
-     public Builder setGroupSort(Sort groupSort) {
-  //      this.groupSort = groupSort;
-        return this;
-      }
-
     public Builder setGroupSortSpec(SortSpec groupSortSpec) {
       this.groupSortSpec = groupSortSpec;
       return this;

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/92b76abd/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java
b/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java
index ffdd7f1..5d6933a 100644
--- a/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java
+++ b/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/TopGroupsFieldCommand.java
@@ -59,21 +59,6 @@ public class TopGroupsFieldCommand implements Command<TopGroups<BytesRef>>
{
       return this;
     }
 
-    //JTODO
-    // We can't reconstruct a SortSpec from a Sort.
-    @Deprecated
-    public Builder setGroupSort(Sort groupSort) {
-  //      this.groupSort = groupSort;
-      return this;
-    }
-
-    // Same as above
-    @Deprecated
-    public Builder setSortWithinGroup(Sort sortWithinGroup) {
-//      this.withinGroupSort = sortWithinGroup;
-      return this;
-    }
-
     public Builder setGroupSortSpec(SortSpec groupSortSpec) {
         this.groupSortSpec = groupSortSpec;
         return this;


Mime
View raw message