lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Solr Wiki] Update of "HowToContribute" by DavidSmiley
Date Wed, 22 Mar 2017 12:54:16 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Solr Wiki" for change notification.

The "HowToContribute" page has been changed by DavidSmiley:
https://wiki.apache.org/solr/HowToContribute?action=diff&rev1=112&rev2=113

Comment:
Remove "all good contributions" are submitted as patches.  PR's are fine too.

  To get correct classpath, formatting, encoding, and project settings in Eclipse, simply
run {{{ant eclipse}}} and then reload the project in Eclipse.  Be sure that you are using
an appropriate version of the Java JDK.  For branch_5x, the minimum version is Java 7 (1.7.x),
for trunk (working towards 6.0), the minimum version is Java 8 (1.8.x).
  
  == Generating a patch ==
- A "patch file" is the format that all good contributions come in.  It bundles up everything
that is being added, removed, or changed in your contribution.
+ A "patch file" is the conventional contribution mechanism.  It bundles up everything that
is being added, removed, or changed in your contribution.  You can instead do a GitHub pull
request, which is documented elsewhere on this apge; nevertheless most of this section is
still applicable.
  
  === Unit Tests ===
  Please make sure that all unit tests succeed before constructing your patch.
@@ -221, +221 @@

  Please be patient.  Committers are busy people too.  If no one responds to your patch after
a few days, please make friendly reminders.  Please incorporate others suggestions into your
patch if you think they're reasonable. Remember that even a patch that is not committed is
useful to the community. Supply first patch as early as possible and updated patches as often
as possible during your work. This helps the rest of the community and committers to start
understanding, help shaping, commenting on etc. your work throughout the entire process. Supplying
a patch does not necessarily mean that it is complete and ready to be committed, it might
also just be a way of communicating your idea and progress.
  
  == Commit process using Git ==
- '''For committers''' Only committers can put the code in the Git repository. We're still
(as of Feb, 2016) in the transition period from SVN to Git and are working out the preferred
process.
+ '''For committers''' Only committers can put the code in the Git repository.
  
  See [[Git commit process]] for the current recommendations.
  

Mime
View raw message