lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From romseyg...@apache.org
Subject lucene-solr:master: SOLR-9132: Fix precommit
Date Fri, 28 Oct 2016 13:08:38 GMT
Repository: lucene-solr
Updated Branches:
  refs/heads/master 1f0641194 -> b6e0ab017


SOLR-9132: Fix precommit


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/b6e0ab01
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/b6e0ab01
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/b6e0ab01

Branch: refs/heads/master
Commit: b6e0ab01743df112dd7ad49135bd33769b7773b7
Parents: 1f06411
Author: Alan Woodward <romseygeek@apache.org>
Authored: Fri Oct 28 13:29:13 2016 +0100
Committer: Alan Woodward <romseygeek@apache.org>
Committed: Fri Oct 28 14:07:51 2016 +0100

----------------------------------------------------------------------
 .../test/org/apache/solr/cloud/CreateCollectionCleanupTest.java  | 1 -
 solr/core/src/test/org/apache/solr/cloud/RecoveryZkTest.java     | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/b6e0ab01/solr/core/src/test/org/apache/solr/cloud/CreateCollectionCleanupTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/cloud/CreateCollectionCleanupTest.java b/solr/core/src/test/org/apache/solr/cloud/CreateCollectionCleanupTest.java
index df7a2e2..869f66c 100644
--- a/solr/core/src/test/org/apache/solr/cloud/CreateCollectionCleanupTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/CreateCollectionCleanupTest.java
@@ -17,7 +17,6 @@
 
 package org.apache.solr.cloud;
 
-import java.util.ArrayList;
 import java.util.Properties;
 
 import org.apache.solr.client.solrj.impl.CloudSolrClient;

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/b6e0ab01/solr/core/src/test/org/apache/solr/cloud/RecoveryZkTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/cloud/RecoveryZkTest.java b/solr/core/src/test/org/apache/solr/cloud/RecoveryZkTest.java
index 0aecdf9..7e30d5c 100644
--- a/solr/core/src/test/org/apache/solr/cloud/RecoveryZkTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/RecoveryZkTest.java
@@ -38,7 +38,7 @@ import org.slf4j.LoggerFactory;
 @Slow
 public class RecoveryZkTest extends SolrCloudTestCase {
 
-  private static Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+  private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
 
   @BeforeClass
   public static void setupCluster() throws Exception {
@@ -140,7 +140,7 @@ public class RecoveryZkTest extends SolrCloudTestCase {
     }
     for (int j = 1; j < replicas.size(); j++) {
       if (numCounts[j] != numCounts[j - 1])
-        fail("Mismatch in counts between replicas");  // nocommit improve this!
+        fail("Mismatch in counts between replicas");  // TODO improve this!
       if (numCounts[j] == 0 && expectDocs)
         fail("Expected docs on shard " + shard.getName() + " but found none");
     }


Mime
View raw message