lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sar...@apache.org
Subject [2/8] lucene-solr:branch_5_5: SOLR-8902: fix glob test (put back the fields.clear())
Date Thu, 16 Jun 2016 13:46:22 GMT
SOLR-8902: fix glob test (put back the fields.clear())


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/5589f9b7
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/5589f9b7
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/5589f9b7

Branch: refs/heads/branch_5_5
Commit: 5589f9b7e705aeefc038e1480b33ede01317b96a
Parents: 252acfe
Author: Ryan McKinley <ryan@apache.org>
Authored: Fri Mar 25 13:49:25 2016 -0700
Committer: Steve Rowe <sarowe@apache.org>
Committed: Wed Jun 15 18:53:48 2016 -0400

----------------------------------------------------------------------
 .../src/java/org/apache/solr/search/SolrReturnFields.java     | 7 +++++++
 1 file changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/5589f9b7/solr/core/src/java/org/apache/solr/search/SolrReturnFields.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/search/SolrReturnFields.java b/solr/core/src/java/org/apache/solr/search/SolrReturnFields.java
index b667f0e..34ef79e 100644
--- a/solr/core/src/java/org/apache/solr/search/SolrReturnFields.java
+++ b/solr/core/src/java/org/apache/solr/search/SolrReturnFields.java
@@ -130,6 +130,13 @@ public class SolrReturnFields extends ReturnFields {
       }
       augmenters.addTransformer( new RenameFieldTransformer( from, to, copy ) );
     }
+    if( !_wantsAllFields && !globs.isEmpty() ) {
+      // TODO??? need to fill up the fields with matching field names in the index
+      // and add them to okFieldNames?
+      // maybe just get all fields?
+      // this would disable field selection optimization... i think thatis OK
+      fields.clear(); // this will get all fields, and use wantsField to limit
+    }
 
     if( augmenters.size() == 1 ) {
       transformer = augmenters.getTransformer(0);


Mime
View raw message