lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sar...@apache.org
Subject [6/6] lucene-solr:branch_5_5: Address Solr Changes.html problems: 1) In addVersion.py: when adding a new version to solr/CHANGES.txt, add a line referring to LUCENE_CHANGES.txt, and add a 'Versions of Major Components' section with versions interpolated
Date Tue, 14 Jun 2016 00:36:45 GMT
Address Solr Changes.html problems: 1) In addVersion.py: when adding a new version to solr/CHANGES.txt,
add a line referring to LUCENE_CHANGES.txt, and add a 'Versions of Major Components' section
with versions interpolated from ivy-versions.properties; and 2) In changes2html.pl: allow
section names to have up to 6 words (to handle 'Upgrading from Solr any prior release')


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/bd3aa459
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/bd3aa459
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/bd3aa459

Branch: refs/heads/branch_5_5
Commit: bd3aa45904c27271f97e3fb1f65f77c5dea3cefb
Parents: 508f8f8
Author: Steve Rowe <sarowe@apache.org>
Authored: Mon Jun 13 20:13:14 2016 -0400
Committer: Steve Rowe <sarowe@apache.org>
Committed: Mon Jun 13 20:26:35 2016 -0400

----------------------------------------------------------------------
 dev-tools/scripts/addVersion.py     | 34 ++++++++++++++++++++++++++++----
 lucene/site/changes/changes2html.pl |  4 ++--
 2 files changed, 32 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/bd3aa459/dev-tools/scripts/addVersion.py
----------------------------------------------------------------------
diff --git a/dev-tools/scripts/addVersion.py b/dev-tools/scripts/addVersion.py
index 414e4a1..4b78c8d 100644
--- a/dev-tools/scripts/addVersion.py
+++ b/dev-tools/scripts/addVersion.py
@@ -20,8 +20,10 @@ from scriptutil import *
 
 import argparse
 import re
+from configparser import ConfigParser, ExtendedInterpolation
+from textwrap import dedent
 
-def update_changes(filename, new_version):
+def update_changes(filename, new_version, init_changes = '(No Changes)\n\n'):
   print('  adding new section to %s...' % filename, end='', flush=True)
   matcher = re.compile(r'\d+\.\d+\.\d+\s+===')
   def edit(buffer, match, line):
@@ -30,7 +32,7 @@ def update_changes(filename, new_version):
     match = new_version.previous_dot_matcher.search(line)
     if match is not None:
       buffer.append(line.replace(match.group(0), new_version.dot))
-      buffer.append('(No Changes)\n\n')
+      buffer.append(init_changes)
     buffer.append(line)
     return match is not None
      
@@ -185,14 +187,38 @@ def read_config():
     parser.error('Adding minor release on master branch requires --changeid')
 
   return c
+
+# Hack ConfigParser, designed to parse INI files, to parse & interpolate Java .properties
files
+def parse_properties_file(filename):
+  contents = open(filename, encoding='ISO-8859-1').read().replace('%', '%%') # Escape interpolation
metachar
+  parser = ConfigParser(interpolation=ExtendedInterpolation())               # Handle ${property-name}
interpolation
+  parser.read_string("[DUMMY_SECTION]\n" + contents)                         # Add required
section
+  return dict(parser.items('DUMMY_SECTION'))
+
+def get_solr_init_changes():
+  return dedent('''
+    Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.
+
+    Versions of Major Components
+    ---------------------
+    Apache Tika %(org.apache.tika.version)s
+    Carrot2 %(/org.carrot2/carrot2-mini)s
+    Velocity %(/org.apache.velocity/velocity)s and Velocity Tools %(/org.apache.velocity/velocity-tools)s
+    Apache UIMA %(org.apache.uima.version)s
+    Apache ZooKeeper %(/org.apache.zookeeper/zookeeper)s
+    Jetty %(org.eclipse.jetty.version)s
+
+
+    (No Changes)\n\n
+    ''' % parse_properties_file('lucene/ivy-versions.properties'))
   
 def main():
   c = read_config() 
 
   print('\nAdding new version %s' % c.version)
   update_changes('lucene/CHANGES.txt', c.version)
-  update_changes('solr/CHANGES.txt', c.version)
-  add_constant(c.version, not c.matching_branch) 
+  update_changes('solr/CHANGES.txt', c.version, get_solr_init_changes())
+  add_constant(c.version, not c.matching_branch)
 
   if not c.changeid:
     print('\nUpdating latest version')

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/bd3aa459/lucene/site/changes/changes2html.pl
----------------------------------------------------------------------
diff --git a/lucene/site/changes/changes2html.pl b/lucene/site/changes/changes2html.pl
index 5399930..d71f296 100755
--- a/lucene/site/changes/changes2html.pl
+++ b/lucene/site/changes/changes2html.pl
@@ -117,10 +117,10 @@ for (my $line_num = 0 ; $line_num <= $#lines ; ++$line_num) {
   }
 
   # Section heading: no leading whitespace, initial word capitalized,
-  #                  five words or less, and no trailing punctuation, 
+  #                  six words or less, and no trailing punctuation,
   #                  except colons - don't match the one otherwise matching
   #                  non-section-name by excluding "StandardTokenizer"
-  if (    /^(?!.*StandardTokenizer)([A-Z]\S*(?:\s+\S+){0,4})(?<![-.;!()])\s*$/
+  if (    /^(?!.*StandardTokenizer)([A-Z]\S*(?:\s+\S+){0,5})(?<![-.;!()])\s*$/
       and not $in_major_component_versions_section) {
     my $heading = $1;
     $heading =~ s/:$//; # Strip trailing colon, if any


Mime
View raw message