lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sar...@apache.org
Subject svn commit: r1723959 - in /lucene/dev/branches/lucene_solr_5_4: ./ dev-tools/ dev-tools/scripts/smokeTestRelease.py
Date Sun, 10 Jan 2016 19:49:32 GMT
Author: sarowe
Date: Sun Jan 10 19:49:31 2016
New Revision: 1723959

URL: http://svn.apache.org/viewvc?rev=1723959&view=rev
Log:
LUCENE-6955: The release smoke tester inappropriately requires back compat index testing for
versions not less than the one being smoke tested (merged trunk r1723956)

Modified:
    lucene/dev/branches/lucene_solr_5_4/   (props changed)
    lucene/dev/branches/lucene_solr_5_4/dev-tools/   (props changed)
    lucene/dev/branches/lucene_solr_5_4/dev-tools/scripts/smokeTestRelease.py

Modified: lucene/dev/branches/lucene_solr_5_4/dev-tools/scripts/smokeTestRelease.py
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_4/dev-tools/scripts/smokeTestRelease.py?rev=1723959&r1=1723958&r2=1723959&view=diff
==============================================================================
--- lucene/dev/branches/lucene_solr_5_4/dev-tools/scripts/smokeTestRelease.py (original)
+++ lucene/dev/branches/lucene_solr_5_4/dev-tools/scripts/smokeTestRelease.py Sun Jan 10 19:49:31
2016
@@ -764,7 +764,7 @@ def verifyUnpacked(java, project, artifa
 
   if project == 'lucene' and isSrc:
     print('  confirm all releases have coverage in TestBackwardsCompatibility')
-    confirmAllReleasesAreTestedForBackCompat(unpackPath)
+    confirmAllReleasesAreTestedForBackCompat(version, unpackPath)
 
 
 def testNotice(unpackPath):
@@ -1318,7 +1318,7 @@ def getAllLuceneReleases():
   l.sort()
   return l
 
-def confirmAllReleasesAreTestedForBackCompat(unpackPath):
+def confirmAllReleasesAreTestedForBackCompat(smokeVersion, unpackPath):
 
   print('    find all past Lucene releases...')
   allReleases = getAllLuceneReleases()
@@ -1378,9 +1378,15 @@ def confirmAllReleasesAreTestedForBackCo
   notTested = []
   for x in allReleases:
     if x not in testedIndices:
-      if '.'.join(str(y) for y in x) in ('1.4.3', '1.9.1', '2.3.1', '2.3.2'):
+      releaseVersion = '.'.join(str(y) for y in x)
+      if releaseVersion in ('1.4.3', '1.9.1', '2.3.1', '2.3.2'):
         # Exempt the dark ages indices
         continue
+      if x >= tuple(int(y) for y in smokeVersion.split('.')):
+        # Exempt versions not less than the one being smoke tested
+        print('      Backcompat testing not required for release %s because it\'s not less
than %s'
+              % (releaseVersion, smokeVersion))
+        continue
       notTested.append(x)
 
   if len(notTested) > 0:



Mime
View raw message