lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sha...@apache.org
Subject svn commit: r1710593 - in /lucene/dev/branches/branch_5x: ./ solr/ solr/core/ solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java
Date Mon, 26 Oct 2015 13:16:30 GMT
Author: shalin
Date: Mon Oct 26 13:16:30 2015
New Revision: 1710593

URL: http://svn.apache.org/viewvc?rev=1710593&view=rev
Log:
Added code comment explaining why this thread pool is unbounded

Modified:
    lucene/dev/branches/branch_5x/   (props changed)
    lucene/dev/branches/branch_5x/solr/   (props changed)
    lucene/dev/branches/branch_5x/solr/core/   (props changed)
    lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java

Modified: lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java?rev=1710593&r1=1710592&r2=1710593&view=diff
==============================================================================
--- lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java
(original)
+++ lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java
Mon Oct 26 13:16:30 2015
@@ -40,7 +40,14 @@ import java.util.concurrent.Executors;
 public class UpdateShardHandler {
   
   private static Logger log = LoggerFactory.getLogger(UpdateShardHandler.class);
-  
+
+  /*
+   * A downside to configuring an upper bound will be big update reorders (when that upper
bound is hit)
+   * and then undetected shard inconsistency as a result.
+   * This update executor is used for different things too... both update streams (which
may be very long lived)
+   * and control messages (peersync? LIR?) and could lead to starvation if limited.
+   * Therefore this thread pool is left unbounded. See SOLR-8205
+   */
   private ExecutorService updateExecutor = ExecutorUtil.newMDCAwareCachedThreadPool(
       new SolrjNamedThreadFactory("updateExecutor"));
   



Mime
View raw message