lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ans...@apache.org
Subject svn commit: r1631145 - /lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestGroupingSearch.java
Date Sun, 12 Oct 2014 04:16:01 GMT
Author: anshum
Date: Sun Oct 12 04:16:00 2014
New Revision: 1631145

URL: http://svn.apache.org/r1631145
Log:
SOLR-5986: Removing a todo that was introduced with a prior commit. It doesn't make any sense
now as partialResults are now returned in all cases where timeAllowed kicks in

Modified:
    lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestGroupingSearch.java

Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestGroupingSearch.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestGroupingSearch.java?rev=1631145&r1=1631144&r2=1631145&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestGroupingSearch.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/TestGroupingSearch.java Sun Oct 12
04:16:00 2014
@@ -278,9 +278,7 @@ public class TestGroupingSearch extends 
     assertU(commit());
 
     // Just checking if no errors occur
-    // TODO: Check if this makes any sense now that timeAllowed is also used during Terms
enumeration.
-    //       The query can potentially timeout iterating over terms if this is set to too
low.
-    assertJQ(req("q", "*:*", "group", "true", "group.query", "id:1", "group.query", "id:2",
"timeAllowed", "100"));
+    assertJQ(req("q", "*:*", "group", "true", "group.query", "id:1", "group.query", "id:2",
"timeAllowed", "1"));
   }
 
   @Test



Mime
View raw message