lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rm...@apache.org
Subject svn commit: r1593239 - in /lucene/dev/branches/branch_4x: ./ lucene/ lucene/core/ lucene/core/src/java/org/apache/lucene/index/SegmentReader.java
Date Thu, 08 May 2014 11:07:50 GMT
Author: rmuir
Date: Thu May  8 11:07:50 2014
New Revision: 1593239

URL: http://svn.apache.org/r1593239
Log:
LUCENE-5656: don't leak dv producers if one of them throws exception

Modified:
    lucene/dev/branches/branch_4x/   (props changed)
    lucene/dev/branches/branch_4x/lucene/   (props changed)
    lucene/dev/branches/branch_4x/lucene/core/   (props changed)
    lucene/dev/branches/branch_4x/lucene/core/src/java/org/apache/lucene/index/SegmentReader.java

Modified: lucene/dev/branches/branch_4x/lucene/core/src/java/org/apache/lucene/index/SegmentReader.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/core/src/java/org/apache/lucene/index/SegmentReader.java?rev=1593239&r1=1593238&r2=1593239&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/lucene/core/src/java/org/apache/lucene/index/SegmentReader.java
(original)
+++ lucene/dev/branches/branch_4x/lucene/core/src/java/org/apache/lucene/index/SegmentReader.java
Thu May  8 11:07:50 2014
@@ -187,13 +187,12 @@ public final class SegmentReader extends
       Long gen = e.getKey();
       List<FieldInfo> infos = e.getValue();
       DocValuesProducer dvp = segDocValues.getDocValuesProducer(gen, si, IOContext.READ,
dir, dvFormat, infos, getTermInfosIndexDivisor());
+      dvGens.add(gen);
       for (FieldInfo fi : infos) {
         dvProducersByField.put(fi.name, dvp);
       }
       dvProducers.add(dvp);
     }
-    
-    dvGens.addAll(genInfos.keySet());
   }
   
   /**



Mime
View raw message