lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rm...@apache.org
Subject svn commit: r1442411 - in /lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index: FieldInfo.java NormsConsumerPerField.java
Date Mon, 04 Feb 2013 22:41:51 GMT
Author: rmuir
Date: Mon Feb  4 22:41:51 2013
New Revision: 1442411

URL: http://svn.apache.org/viewvc?rev=1442411&view=rev
Log:
clear nocommits

Modified:
    lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java
    lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java

Modified: lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java?rev=1442411&r1=1442410&r2=1442411&view=diff
==============================================================================
--- lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java
(original)
+++ lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java
Mon Feb  4 22:41:51 2013
@@ -234,7 +234,6 @@ public final class FieldInfo {
     assert checkConsistency();
   }
 
-  // nocommit type is always number?  should we remove this?
   void setNormValueType(DocValuesType type) {
     if (normType != null && normType != type) {
       throw new IllegalArgumentException("cannot change Norm type from " + normType + " to
" + type + " for field \"" + name + "\"");

Modified: lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java?rev=1442411&r1=1442410&r2=1442411&view=diff
==============================================================================
--- lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java
(original)
+++ lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java
Mon Feb  4 22:41:51 2013
@@ -43,8 +43,6 @@ final class NormsConsumerPerField extend
   void finish() throws IOException {
     if (fieldInfo.isIndexed() && !fieldInfo.omitsNorms()) {
       if (consumer == null) {
-        // nocommit wrongish?  what about the
-        // only-doc-with-norms-enabled-hits-exc case?
         fieldInfo.setNormValueType(FieldInfo.DocValuesType.NUMERIC);
         consumer = new NumericDocValuesWriter(fieldInfo, docState.docWriter.bytesUsed);
       }
@@ -56,8 +54,8 @@ final class NormsConsumerPerField extend
     int docCount = state.segmentInfo.getDocCount();
     if (consumer == null) {
       return; // null type - not omitted but not written -
-              // nocommit meaning the only docs that had
-              // norms hit exceptions?
+              // meaning the only docs that had
+              // norms hit exceptions (but indexed=true is set...)
     }
     consumer.finish(docCount);
     consumer.flush(state, normsWriter);



Mime
View raw message