lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rm...@apache.org
Subject svn commit: r1440840 - /lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocFieldProcessor.java
Date Thu, 31 Jan 2013 04:05:33 GMT
Author: rmuir
Date: Thu Jan 31 04:05:32 2013
New Revision: 1440840

URL: http://svn.apache.org/viewvc?rev=1440840&view=rev
Log:
trade one nocommit for another

Modified:
    lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocFieldProcessor.java

Modified: lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocFieldProcessor.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocFieldProcessor.java?rev=1440840&r1=1440839&r2=1440840&view=diff
==============================================================================
--- lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocFieldProcessor.java
(original)
+++ lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocFieldProcessor.java
Thu Jan 31 04:05:32 2013
@@ -253,10 +253,10 @@ final class DocFieldProcessor extends Do
         rehash();
       }
     } else {
-      // nocommit this is wasteful: it's another hash lookup
-      // by field name; can we just do fp.fieldInfo.update
-      // directly?
-      fieldInfos.addOrUpdate(fp.fieldInfo.name, ft);
+      // nocommit: dangerous: maybe FI.update()/FI ctor()/FIS.addOrUpdate need only take
FT
+      // instead of a thousand parameters? Surely we can make this better... like:
+      // fp.fieldInfo.update(ft);
+      fp.fieldInfo.update(ft.indexed(), false, ft.omitNorms(), false, ft.indexOptions());
     }
 
     if (thisFieldGen != fp.lastGen) {



Mime
View raw message