Return-Path: X-Original-To: apmail-lucene-commits-archive@www.apache.org Delivered-To: apmail-lucene-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F00C4EA6D for ; Thu, 22 Nov 2012 13:07:29 +0000 (UTC) Received: (qmail 96117 invoked by uid 500); 22 Nov 2012 13:07:21 -0000 Mailing-List: contact commits-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list commits@lucene.apache.org Received: (qmail 96085 invoked by uid 99); 22 Nov 2012 13:07:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Nov 2012 13:07:20 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Nov 2012 13:07:19 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 9948B2388906; Thu, 22 Nov 2012 13:06:57 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1412538 - in /lucene/dev/trunk/lucene/core/src/java/org/apache/lucene: codecs/lucene40/values/VarStraightBytesImpl.java util/packed/PackedInts.java Date: Thu, 22 Nov 2012 13:06:57 -0000 To: commits@lucene.apache.org From: jpountz@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121122130657.9948B2388906@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jpountz Date: Thu Nov 22 13:06:56 2012 New Revision: 1412538 URL: http://svn.apache.org/viewvc?rev=1412538&view=rev Log: PackedInts.ReaderIterator should not be closeable. Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene40/values/VarStraightBytesImpl.java lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene40/values/VarStraightBytesImpl.java URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene40/values/VarStraightBytesImpl.java?rev=1412538&r1=1412537&r2=1412538&view=diff ============================================================================== --- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene40/values/VarStraightBytesImpl.java (original) +++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene40/values/VarStraightBytesImpl.java Thu Nov 22 13:06:56 2012 @@ -134,7 +134,6 @@ class VarStraightBytesImpl { docToAddress[lastDocID] = address + offset; } address += numDataBytes; // this is the address after all addr pointers are updated - iter.close(); } finally { IOUtils.close(cloneIdx); } Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java?rev=1412538&r1=1412537&r2=1412538&view=diff ============================================================================== --- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java (original) +++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java Thu Nov 22 13:06:56 2012 @@ -17,7 +17,6 @@ package org.apache.lucene.util.packed; * limitations under the License. */ -import java.io.Closeable; import java.io.IOException; import org.apache.lucene.codecs.CodecUtil; @@ -475,7 +474,7 @@ public class PackedInts { /** * Run-once iterator interface, to decode previously saved PackedInts. */ - public static interface ReaderIterator extends Closeable { + public static interface ReaderIterator { /** Returns next value */ long next() throws IOException; /** Returns at least 1 and at most count next values, @@ -520,13 +519,6 @@ public class PackedInts { public int size() { return valueCount; } - - @Override - public void close() throws IOException { - if (in instanceof Closeable) { - ((Closeable) in).close(); - } - } } /**