lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rm...@apache.org
Subject svn commit: r1201393 - in /lucene/dev/trunk/lucene/src: java/org/apache/lucene/index/TermsEnum.java test/org/apache/lucene/search/TestNumericRangeQuery32.java test/org/apache/lucene/search/TestNumericRangeQuery64.java
Date Sun, 13 Nov 2011 02:12:56 GMT
Author: rmuir
Date: Sun Nov 13 02:12:56 2011
New Revision: 1201393

URL: http://svn.apache.org/viewvc?rev=1201393&view=rev
Log:
LUCENE-3314: disable check to prevent false fails and expand javadocs

Modified:
    lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/TermsEnum.java
    lucene/dev/trunk/lucene/src/test/org/apache/lucene/search/TestNumericRangeQuery32.java
    lucene/dev/trunk/lucene/src/test/org/apache/lucene/search/TestNumericRangeQuery64.java

Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/TermsEnum.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/TermsEnum.java?rev=1201393&r1=1201392&r2=1201393&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/TermsEnum.java (original)
+++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/TermsEnum.java Sun Nov 13 02:12:56
2011
@@ -117,7 +117,9 @@ public abstract class TermsEnum {
   /** Increments the enumeration to the next term.
    *  Returns the resulting term, or null if the end was
    *  hit (which means the enum is unpositioned).  The
-   *  returned BytesRef may be re-used across calls to next. */
+   *  returned BytesRef may be re-used across calls to next.
+   *  After this method returns null, do not call it again:
+   *  the results are undefined. */
   public abstract BytesRef next() throws IOException;
 
   /** Returns current term. Do not call this when the enum

Modified: lucene/dev/trunk/lucene/src/test/org/apache/lucene/search/TestNumericRangeQuery32.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/test/org/apache/lucene/search/TestNumericRangeQuery32.java?rev=1201393&r1=1201392&r2=1201393&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/test/org/apache/lucene/search/TestNumericRangeQuery32.java
(original)
+++ lucene/dev/trunk/lucene/src/test/org/apache/lucene/search/TestNumericRangeQuery32.java
Sun Nov 13 02:12:56 2011
@@ -408,7 +408,8 @@ public class TestNumericRangeQuery32 ext
       }
       last = new BytesRef(cur);
     } 
-    assertNull(termEnum.next());
+    // LUCENE-3314: the results after next() already returned null are undefined,
+    // assertNull(termEnum.next());
     return count;
   }
   

Modified: lucene/dev/trunk/lucene/src/test/org/apache/lucene/search/TestNumericRangeQuery64.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/test/org/apache/lucene/search/TestNumericRangeQuery64.java?rev=1201393&r1=1201392&r2=1201393&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/test/org/apache/lucene/search/TestNumericRangeQuery64.java
(original)
+++ lucene/dev/trunk/lucene/src/test/org/apache/lucene/search/TestNumericRangeQuery64.java
Sun Nov 13 02:12:56 2011
@@ -428,7 +428,8 @@ public class TestNumericRangeQuery64 ext
       }
       last = new BytesRef(cur);
     } 
-    assertNull(termEnum.next());
+    // LUCENE-3314: the results after next() already returned null are undefined,
+    // assertNull(termEnum.next());
     return count;
   }
   



Mime
View raw message