lucene-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rm...@apache.org
Subject svn commit: r1153716 - /lucene/dev/branches/blocktree_3030/lucene/src/java/org/apache/lucene/search/FuzzyTermsEnum.java
Date Thu, 04 Aug 2011 01:13:30 GMT
Author: rmuir
Date: Thu Aug  4 01:13:29 2011
New Revision: 1153716

URL: http://svn.apache.org/viewvc?rev=1153716&view=rev
Log:
add comments to nocommits

Modified:
    lucene/dev/branches/blocktree_3030/lucene/src/java/org/apache/lucene/search/FuzzyTermsEnum.java

Modified: lucene/dev/branches/blocktree_3030/lucene/src/java/org/apache/lucene/search/FuzzyTermsEnum.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/blocktree_3030/lucene/src/java/org/apache/lucene/search/FuzzyTermsEnum.java?rev=1153716&r1=1153715&r2=1153716&view=diff
==============================================================================
--- lucene/dev/branches/blocktree_3030/lucene/src/java/org/apache/lucene/search/FuzzyTermsEnum.java
(original)
+++ lucene/dev/branches/blocktree_3030/lucene/src/java/org/apache/lucene/search/FuzzyTermsEnum.java
Thu Aug  4 01:13:29 2011
@@ -157,6 +157,8 @@ public final class FuzzyTermsEnum extend
   /** initialize levenshtein DFAs up to maxDistance, if possible */
   private List<CompiledAutomaton> initAutomata(int maxDistance) {
     // nocommit -- is this called multiple times per query!?
+    // it shouldn't be, its getting this list from the attribute,
+    // which preserves the CAs across segments (only Uwe really knows if it works)
     final List<CompiledAutomaton> runAutomata = dfaAtt.automata();
     if (runAutomata.size() <= maxDistance && 
         maxDistance <= LevenshteinAutomata.MAXIMUM_SUPPORTED_DISTANCE) {
@@ -334,6 +336,9 @@ public final class FuzzyTermsEnum extend
     // nocommit -- we lost the more efficient (always seek)
     // accept for FuzzyTermsEnum in Terms.intersect!  so on
     // non-intersect-capable terms dicts this is slower?
+
+    // Yes: this is totally broken. It never seeks ever for e.g. preflex
+    
     // maybe we stuff a hint (boolean alwaysSeek) into CA?
 
     /** finds the smallest Lev(n) DFA that accepts the term. */



Mime
View raw message