logging-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (LOG4J2-2754) LoaderUtil.getClassLoaders fails to update loop state
Date Tue, 31 Dec 2019 20:14:00 GMT

     [ https://issues.apache.org/jira/browse/LOG4J2-2754?focusedWorklogId=365071&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365071
]

ASF GitHub Bot logged work on LOG4J2-2754:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Dec/19 20:13
            Start Date: 31/Dec/19 20:13
    Worklog Time Spent: 10m 
      Work Description: carterkozak commented on pull request #328: LOG4J2-2754: LoaderUtil.getClassLoaders
may discover additional loaders
URL: https://github.com/apache/logging-log4j2/pull/328#discussion_r362274678
 
 

 ##########
 File path: log4j-api/src/main/java/org/apache/logging/log4j/util/LoaderUtil.java
 ##########
 @@ -106,30 +104,31 @@ public ClassLoader run() {
     }
 
     public static ClassLoader[] getClassLoaders() {
-        final List<ClassLoader> classLoaders = new ArrayList<>();
+        final Collection<ClassLoader> classLoaders = new LinkedHashSet<>();
 
 Review comment:
   LinkedHashSet is more expensive in environments with few values, but performs better in
the worst case without sacrificing order.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 365071)
    Time Spent: 0.5h  (was: 20m)

> LoaderUtil.getClassLoaders fails to update loop state
> -----------------------------------------------------
>
>                 Key: LOG4J2-2754
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2754
>             Project: Log4j 2
>          Issue Type: Bug
>    Affects Versions: 2.13.0
>            Reporter: Carter Kozak
>            Assignee: Carter Kozak
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Same problem as LOG4J2-2104, but for final 'ClassLoader current = LoaderUtil.class.getClassLoader();'
> The while loop acts as a simple conditional (unless a classloader is defined with an
incorrect 'equals' method, then it loops infinitely -- I've not seen this behavior in practice
though).
> It appears that getThreadContextClassLoader can return a null ClassLoader, which ends
up in the getClassLoaders result erroneously.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message