The Buildbot has detected a failed build of log4php-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/log4php-trunk/builds/281 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: ceres_ubuntu Build Reason: forced: by IRC user <gmcdonald> on channel #asftest: testing mail notifier Build Source Stamp: HEAD Blamelist: BUILD FAILED: failed compile sincerely, -The Buildbot
The log4php-dev vote was opened on Nov 27, 2009 and closed on Dec 4, 2009. Binding +1 votes were received from Christian Grobmeier, Christian Hammers and Curt Arnold. No other votes were received. Christian has called for a vote on general@incubator.apache.org at http://mail-archives.apache.org/mod_mbox/incubator-general/200912.mbox/%3cded132f10912050048u695e1353ta29b54a39e620c57@mail.gmail.com%3e
Dear Incubator PMC, the Log4PHP has voted with 3x +1 for releasing RC3 as Log4PHP 2.0.0 (please see below). The original vote message can be found: http://mail-archives.apache.org/mod_mbox/logging-log4php-dev/200911.mbox/%3cded132f10911262256j12c0cfej21e7e5dbdcf18bf7@mail.gmail.com%3e Message ID is: ded132f10911262256j12c0cfej21e7e5dbdcf18bf7 We kindly ask the incubator PMC to vote on our artifacts too: [ ] +1 Yes go ahead and release the artifacts [ ] -1 No, because... Thanks, Christian ---------- Forwarded message ---------- From: Christian Grobmeier <grobmeier@gmail.com> Date: Fri, Nov 27, 2009 at 7:56 AM Subject: [VOTE] Release RC3 as Log4PHP 2.0.0 To: Log4PHP Dev <log4php-dev@logging.apache.org> Dear all, please vote to release the following artifacts as version 2.0.0: [ ] +1 Yes go ahead and release the artifacts [ ] -1 No, because... Log4PHP 2.0.0 artifacts are available for review here: Â * http://people.apache.org/builds/logging/log4php/2.0.0/RC3/ The release plan used for the creation of the packages is here: Â * http://wiki.apache.org/logging/Log4PHP/Log4PHPReleasePlan The tag for this release is available here: Â * http://svn.apache.org/viewvc/incubator/log4php/tags/apache-log4php-2.0.0-incubating/ Differences to the last RC: - licensing issues - move api to docs folder - renamed assembly descriptor to src.xml (indstead of bin.xml) Please also help with checking signatures, md5 files and about all license stuff. A short help can be found on the release plan page. Thanks, Christian
Dear Incubator PMC, the Log4PHP has voted with 3x +1 for releasing RC3 as Log4PHP 2.0.0 (please see below). The original vote message can be found: http://mail-archives.apache.org/mod_mbox/logging-log4php-dev/200911.mbox/%3cded132f10911262256j12c0cfej21e7e5dbdcf18bf7@mail.gmail.com%3e Message ID is: ded132f10911262256j12c0cfej21e7e5dbdcf18bf7 We kindly ask the incubator PMC to vote on our artifacts too: [ ] +1 Yes go ahead and release the artifacts [ ] -1 No, because... Thanks, Christian ---------- Forwarded message ---------- From: Christian Grobmeier <grobmeier@gmail.com> Date: Fri, Nov 27, 2009 at 7:56 AM Subject: [VOTE] Release RC3 as Log4PHP 2.0.0 To: Log4PHP Dev <log4php-dev@logging.apache.org> Dear all, please vote to release the following artifacts as version 2.0.0: [ ] +1 Yes go ahead and release the artifacts [ ] -1 No, because... Log4PHP 2.0.0 artifacts are available for review here: Â * http://people.apache.org/builds/logging/log4php/2.0.0/RC3/ The release plan used for the creation of the packages is here: Â * http://wiki.apache.org/logging/Log4PHP/Log4PHPReleasePlan The tag for this release is available here: Â * http://svn.apache.org/viewvc/incubator/log4php/tags/apache-log4php-2.0.0-incubating/ Differences to the last RC: - licensing issues - move api to docs folder - renamed assembly descriptor to src.xml (indstead of bin.xml) Please also help with checking signatures, md5 files and about all license stuff. A short help can be found on the release plan page. Thanks, Christian
But not ready for the report, which needs to be done until 9th :-) However, I submitted it now to: http://wiki.apache.org/incubator/December2009 If some of guys have changes, please put them there too. And mentors, please don't forget to sign off :-) Thanks Christian On Wed, Dec 2, 2009 at 5:35 PM, Christian Hammers <ch@lathspell.de> wrote: > We already got my and your vote, if Gavin gives a +1 we could even > report that we *have* a Release 2.0 ready for Xmas! :) > > And with a release there comes at least the hope of any communtiy feedback. > > bye, > > -christian- > > > > On Wed, 2 Dec 2009 14:38:51 +0100 > Christian Grobmeier <grobmeier@gmail.com> wrote: > >> Hi guys, >> >> we have a board report to do. Please feel free to add something to: >> http://wiki.apache.org/logging/Log4PHP/BoardReportsDrafts >> >> Currently it is: >> >> December 2009 >> Log4PHP is a logging framework similar to Log4J, but in PHP. The >> project entered incubation in 2004, retired and restarted again on >> 2007-07-04. The project got some community feedback, which is good, >> but not enough for graduation. >> >> Christian Hammers has been elected as new Committer >> The Log4PHP team created 3 release candidates. We are currently voting >> on them and will bring the proposed release on the incubator list >> soon. >> >> >> Best, >> Christian >
On Dec 3, 2009, at 4:45 PM, Christian Grobmeier wrote: > Thanks Curt! I appreciate your effort and will document your installation guide > How many +1 are necessary for pushing forward? > Three binding +1's and 72 hours elapsed is the general practice. I checked the asf-authorization file and all three +1's are in the logging-log4php group which is my best approximation of the PPMC membership list, so I think we have three binding votes and we've exceeded 72 hours. I think we are good to go to the Incubator PMC. http://incubator.apache.org/guides/releasemanagement.html#release-guidelines > > Incubator Release Vote > > All releases by podlings must be approved by the TODO: link Incubator PMC. The conventional process is for the podling to follow the usual Apache process (including TODO: link release vote) and then call for a Incubator PMC VOTE on the TODO: link general incubator list. > > The release manager should post the call for the VOTE. > > • Links to the release artifacts > • Links to the PPMC release vote thread > • Link to the tag from which the release is cut > > Release managers should subscribe to a number of Apache-wide mailing lists. Decisions are taken on these mailing lists and issues resolved. Documentation is updated later (if at all). It's important that release managers ensure that they keep up to date. > > • TODO: link General infrastructure list > • TODO: link Legal discuss list > Release managers for incubating podlings should also subscribe to the TODO: link general list.
Thanks Curt! I appreciate your effort and will document your installation guide How many +1 are necessary for pushing forward? On Thu, Dec 3, 2009 at 4:12 AM, Curt Arnold <carnold@apache.org> wrote: > I was able to nearly rebuild the release which had only minor variations from in the generated documentation. Â Every generated docfile had a "Documentation generated by" timestamp which obviously varied. Â The other issue is that my check build had a few places where classes appeared in different order (Direct Dependents in docs/log4php/LoggerAppender.html, for example). Â The release build was alphabetically sorted while mine had no obvious sort order. > > Took a little trial and error to get a configuration down, but from a non stock Ubuntu 9.04 with Sun Java 6, Apache Maven 2 and PHP 5 already installed, I still needed to do: > > sudo pear upgrade PEAR > sudo pear channel-discover pear.phpunit.de > sudo pear install phpunit/PHPUnit > sudo apt-get install php5-xdebug > sudo pear install XML_Serializer-0.19.2 > sudo pear install --alldeps PEAR_PackageFileManager2 > > > Then ran: > > mvn site assembly:assembly > > mvn rat:check reports that many of the generated documentation files do not have ASF source file headers as previously noted. > > Reproducible, no obvious legal issues other than the generated doc issue. Â Here is my +1 to push it to the Incubator PMC. > > >
I was able to nearly rebuild the release which had only minor variations from in the generated documentation. Every generated docfile had a "Documentation generated by" timestamp which obviously varied. The other issue is that my check build had a few places where classes appeared in different order (Direct Dependents in docs/log4php/LoggerAppender.html, for example). The release build was alphabetically sorted while mine had no obvious sort order. Took a little trial and error to get a configuration down, but from a non stock Ubuntu 9.04 with Sun Java 6, Apache Maven 2 and PHP 5 already installed, I still needed to do: sudo pear upgrade PEAR sudo pear channel-discover pear.phpunit.de sudo pear install phpunit/PHPUnit sudo apt-get install php5-xdebug sudo pear install XML_Serializer-0.19.2 sudo pear install --alldeps PEAR_PackageFileManager2 Then ran: mvn site assembly:assembly mvn rat:check reports that many of the generated documentation files do not have ASF source file headers as previously noted. Reproducible, no obvious legal issues other than the generated doc issue. Here is my +1 to push it to the Incubator PMC.
We already got my and your vote, if Gavin gives a +1 we could even report that we *have* a Release 2.0 ready for Xmas! :) And with a release there comes at least the hope of any communtiy feedback. bye, -christian- On Wed, 2 Dec 2009 14:38:51 +0100 Christian Grobmeier <grobmeier@gmail.com> wrote: > Hi guys, > > we have a board report to do. Please feel free to add something to: > http://wiki.apache.org/logging/Log4PHP/BoardReportsDrafts > > Currently it is: > > December 2009 > Log4PHP is a logging framework similar to Log4J, but in PHP. The > project entered incubation in 2004, retired and restarted again on > 2007-07-04. The project got some community feedback, which is good, > but not enough for graduation. > > Christian Hammers has been elected as new Committer > The Log4PHP team created 3 release candidates. We are currently voting > on them and will bring the proposed release on the incubator list > soon. > > > Best, > Christian
Hi guys, we have a board report to do. Please feel free to add something to: http://wiki.apache.org/logging/Log4PHP/BoardReportsDrafts Currently it is: December 2009 Log4PHP is a logging framework similar to Log4J, but in PHP. The project entered incubation in 2004, retired and restarted again on 2007-07-04. The project got some community feedback, which is good, but not enough for graduation. Christian Hammers has been elected as new Committer The Log4PHP team created 3 release candidates. We are currently voting on them and will bring the proposed release on the incubator list soon. Best, Christian
Hello +1 bye, -christian- Am Fri, 27 Nov 2009 07:56:11 +0100 schrieb Christian Grobmeier <grobmeier@gmail.com>: > Dear all, > > please vote to release the following artifacts as version 2.0.0: > > [ ] +1 Yes go ahead and release the artifacts > [ ] -1 No, because... > > Log4PHP 2.0.0 artifacts are available for review here: > * http://people.apache.org/builds/logging/log4php/2.0.0/RC3/ > > The release plan used for the creation of the packages is here: > * http://wiki.apache.org/logging/Log4PHP/Log4PHPReleasePlan > > The tag for this release is available here: > * > http://svn.apache.org/viewvc/incubator/log4php/tags/apache-log4php-2.0.0-incubating/ > > Differences to the last RC: > - licensing issues > - move api to docs folder > - renamed assembly descriptor to src.xml (indstead of bin.xml) > > Please also help with checking signatures, md5 files and about all > license stuff. A short help can be found on the release plan page. > > Thanks, > Christian
Dear all, please vote to release the following artifacts as version 2.0.0: [ ] +1 Yes go ahead and release the artifacts [ ] -1 No, because... Log4PHP 2.0.0 artifacts are available for review here: * http://people.apache.org/builds/logging/log4php/2.0.0/RC3/ The release plan used for the creation of the packages is here: * http://wiki.apache.org/logging/Log4PHP/Log4PHPReleasePlan The tag for this release is available here: * http://svn.apache.org/viewvc/incubator/log4php/tags/apache-log4php-2.0.0-incubating/ Differences to the last RC: - licensing issues - move api to docs folder - renamed assembly descriptor to src.xml (indstead of bin.xml) Please also help with checking signatures, md5 files and about all license stuff. A short help can be found on the release plan page. Thanks, Christian
This vote is invalid of course - i start a new one Thanks for all comments On Mon, Nov 23, 2009 at 7:00 AM, Christian Grobmeier <grobmeier@gmail.com> wrote: > Dear all, > > please vote to release the following artifacts as version 2.0.0: > > [ ] +1 Yes go ahead and release the artifacts > [ ] -1 No, because... > > Log4PHP 2.0.0 artifacts are available for review here: > Â * http://people.apache.org/builds/logging/log4php/2.0.0/RC2/ > > The release plan used for the creation of the packages is here: > Â * http://wiki.apache.org/logging/Log4PHP/Log4PHPReleasePlan > > The tag for this release is available here: > Â * http://svn.apache.org/viewvc/incubator/log4php/tags/apache-log4php-2.0.0-incubating/ > > Differences to the last RC: > - license issue for the examples has been sorted out > - corrected the wrong directory name > - svn mv old release candidate to RC1 as tagname > > Please also help with checking signatures, md5 files and about all > license stuff. A short help can be found on the release plan page. > > Thanks, > Christian >
Author: grobmeier
Date: Fri Nov 27 06:42:46 2009
New Revision: 884754
URL: http://svn.apache.org/viewvc?rev=884754&view=rev
Log:
[maven-release-plugin] prepare for next development iteration
Modified:
incubator/log4php/trunk/pom.xml
Modified: incubator/log4php/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/pom.xml?rev=884754&r1=884753&r2=884754&view=diff
==============================================================================
--- incubator/log4php/trunk/pom.xml (original)
+++ incubator/log4php/trunk/pom.xml Fri Nov 27 06:42:46 2009
@@ -19,7 +19,7 @@
<groupId>org.apache.log4php</groupId>
<artifactId>apache-log4php</artifactId>
<packaging>jar</packaging>
- <version>2.0.0-incubating</version>
+ <version>2.0.1-incubating-SNAPSHOT</version>
<name>Apache log4php.</name>
<description>Logging framework for PHP.</description>
<url>http://incubator.apache.org:80/log4php</url>
@@ -57,9 +57,9 @@
</license>
</licenses>
<scm>
- <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/log4php/tags/apache-log4php-2.0.0-incubating</connection>
- <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/log4php/tags/apache-log4php-2.0.0-incubating</developerConnection>
- <url>http://svn.apache.org/viewcvs.cgi/incubator/log4php/tags/apache-log4php-2.0.0-incubating</url>
+ <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/log4php/trunk</connection>
+ <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/log4php/trunk</developerConnection>
+ <url>http://svn.apache.org/viewcvs.cgi/incubator/log4php/trunk</url>
</scm>
<organization>
<name>Apache Software Foundation</name>
Author: grobmeier
Date: Fri Nov 27 06:42:31 2009
New Revision: 884753
URL: http://svn.apache.org/viewvc?rev=884753&view=rev
Log:
[maven-scm] copy for tag apache-log4php-2.0.0-incubating
Added:
incubator/log4php/tags/apache-log4php-2.0.0-incubating/
- copied from r884752, incubator/log4php/trunk/
Author: grobmeier
Date: Fri Nov 27 06:42:02 2009
New Revision: 884752
URL: http://svn.apache.org/viewvc?rev=884752&view=rev
Log:
[maven-release-plugin] prepare release apache-log4php-2.0.0-incubating
Modified:
incubator/log4php/trunk/pom.xml
Modified: incubator/log4php/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/pom.xml?rev=884752&r1=884751&r2=884752&view=diff
==============================================================================
--- incubator/log4php/trunk/pom.xml (original)
+++ incubator/log4php/trunk/pom.xml Fri Nov 27 06:42:02 2009
@@ -19,7 +19,7 @@
<groupId>org.apache.log4php</groupId>
<artifactId>apache-log4php</artifactId>
<packaging>jar</packaging>
- <version>2.0.0-incubating-SNAPSHOT</version>
+ <version>2.0.0-incubating</version>
<name>Apache log4php.</name>
<description>Logging framework for PHP.</description>
<url>http://incubator.apache.org:80/log4php</url>
@@ -57,9 +57,9 @@
</license>
</licenses>
<scm>
- <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/log4php/trunk</connection>
- <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/log4php/trunk</developerConnection>
- <url>http://svn.apache.org/viewcvs.cgi/incubator/log4php/trunk</url>
+ <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/log4php/tags/apache-log4php-2.0.0-incubating</connection>
+ <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/log4php/tags/apache-log4php-2.0.0-incubating</developerConnection>
+ <url>http://svn.apache.org/viewcvs.cgi/incubator/log4php/tags/apache-log4php-2.0.0-incubating</url>
</scm>
<organization>
<name>Apache Software Foundation</name>
Hi, thanks Christian to making those fixes so quickly :-) > Â > 3. Generated docs placed in target/site directory. >> target is the default build directory for maven. Â Typically, the site >> built with the release is placed in doc, leaving the target directory >> available for end-user builds. > > Hmm... the maven-javadoc-plugin and maven-assembly-plugin as I know it > from other projects always use the target/ directory. > And if a programmer executes "mvn site" or similar, well then I would > expect nothing else than that he of course overwrites the released > api documentation as well as the released zip files because that's > just what a build is supposed to. I think we should simply move it out (already done :-)) - hope thats ok for you too. I thought about it and felt that I would expect a docs directory too Best, Christian
Author: grobmeier
Date: Fri Nov 27 06:30:17 2009
New Revision: 884749
URL: http://svn.apache.org/viewvc?rev=884749&view=rev
Log:
moved apidocs from target to docs dir in final build
Modified:
incubator/log4php/trunk/src/assembly/src.xml
Modified: incubator/log4php/trunk/src/assembly/src.xml
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/assembly/src.xml?rev=884749&r1=884748&r2=884749&view=diff
==============================================================================
--- incubator/log4php/trunk/src/assembly/src.xml (original)
+++ incubator/log4php/trunk/src/assembly/src.xml Fri Nov 27 06:30:17 2009
@@ -39,8 +39,11 @@
<include>package-config.php</include>
<include>package.php</include>
<include>src/**</include>
- <include>target/site/apidocs/**</include>
</includes>
</fileSet>
+ <fileSet>
+ <directory>target/site/apidocs</directory>
+ <outputDirectory>docs</outputDirectory>
+ </fileSet>
</fileSets>
</assembly>
Author: grobmeier
Date: Fri Nov 27 06:15:01 2009
New Revision: 884748
URL: http://svn.apache.org/viewvc?rev=884748&view=rev
Log:
renamed since we do not build binaries
Added:
incubator/log4php/trunk/src/assembly/src.xml
- copied unchanged from r884747, incubator/log4php/trunk/src/assembly/bin.xml
Removed:
incubator/log4php/trunk/src/assembly/bin.xml
Author: grobmeier
Date: Fri Nov 27 06:12:32 2009
New Revision: 884747
URL: http://svn.apache.org/viewvc?rev=884747&view=rev
Log:
renamed because of rejection of RC2
Added:
incubator/log4php/tags/apache-log4php-2.0.0-incubating-RC2/
- copied from r884746, incubator/log4php/tags/apache-log4php-2.0.0-incubating/
Removed:
incubator/log4php/tags/apache-log4php-2.0.0-incubating/
Author: grobmeier
Date: Fri Nov 27 06:07:41 2009
New Revision: 884745
URL: http://svn.apache.org/viewvc?rev=884745&view=rev
Log:
reverted to 2.0.0 for next RC
corrected view-svn link to trunk
Modified:
incubator/log4php/trunk/pom.xml
Modified: incubator/log4php/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/pom.xml?rev=884745&r1=884744&r2=884745&view=diff
==============================================================================
--- incubator/log4php/trunk/pom.xml (original)
+++ incubator/log4php/trunk/pom.xml Fri Nov 27 06:07:41 2009
@@ -19,7 +19,7 @@
<groupId>org.apache.log4php</groupId>
<artifactId>apache-log4php</artifactId>
<packaging>jar</packaging>
- <version>2.0.1-incubating-SNAPSHOT</version>
+ <version>2.0.0-incubating-SNAPSHOT</version>
<name>Apache log4php.</name>
<description>Logging framework for PHP.</description>
<url>http://incubator.apache.org:80/log4php</url>
@@ -59,7 +59,7 @@
<scm>
<connection>scm:svn:http://svn.apache.org/repos/asf/incubator/log4php/trunk</connection>
<developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/log4php/trunk</developerConnection>
- <url>http://svn.apache.org/viewcvs.cgi/incubator/log4php/apache-log4php-2.0.0-incubating</url>
+ <url>http://svn.apache.org/viewcvs.cgi/incubator/log4php/trunk</url>
</scm>
<organization>
<name>Apache Software Foundation</name>
Hello Am Wed, 25 Nov 2009 20:13:58 -0600 schrieb Curt Arnold <carnold@apache.org>: > Got a couple of issues with the docs, in order of significance: > > > 1. No "Apache", version number or incubating disclaimer on generated > docs. The generated docs have a generic title "Generated > Documentation" and log4php stands by itself, really should be "Apache > log4php 2.0.0 (incubating)" or something like that. Fixed in r884717 > 2. No ASF header in generated docs > > From http://www.apache.org/legal/src-headers.html > > > What if my project includes its web site within a product > > distribution? > > > > With few exceptions, all human-readable Apache-developed files that > > are included within a distribution must include the header text. > > Documentation, including web site documentation distributed with > > the release, may include the header text within some form of > > metadata (such as HTML comments) or as a header or footer appearing > > in the visible documentation. > > Also > http://incubator.apache.org/guides/releasemanagement.html#notes-license-headers > > > > The issue of licenses on generated documentation is a little > > controversial. Copyright may not subsist in a document which is > > generated by an transformation from an original. In which case, the > > license header may be unnecessary. License headers should always be > > present in the original. Where it is reasonable to do so, the > > templates should also add the license header to the generated > > documents. > > > > > If the license header could be templated in as an HTML comment, it > would eliminate this as a point of contention. Oh, those license-o-maniacs are beginning to go me on my nerves! :-/ All source code files carry the license and if one clicks on "files" instead of "classes" they are shown. As I found no way to easily customize the generated HTML files, played around with the phpdoc tutorial function and found a way to alter the start page which now prints only the license. If that's not enough somebody else may spend his time on this. > 3. Generated docs placed in target/site directory. > > target is the default build directory for maven. Typically, the site > built with the release is placed in doc, leaving the target directory > available for end-user builds. Otherwise, it is easy for a Java > developer to inadvertently write over the released documentation. > The "includeSiteDirectory" descriptor in Maven's assembly plugin > isn't adequately described, but I'm guessing it works with the > javadoc plugin and does that relocation automatically, but it doesn't > do the same for phpdoc. Hmm... the maven-javadoc-plugin and maven-assembly-plugin as I know it from other projects always use the target/ directory. And if a programmer executes "mvn site" or similar, well then I would expect nothing else than that he of course overwrites the released api documentation as well as the released zip files because that's just what a build is supposed to. Or the other way around if a programmer deliberately changes something in our files then he expect changes in the apidocs and will be very confused when the one he has open in his browser (doc/apidocs/) will not change because we regenerated them in target/site/apidocs. Or maybe I misunderstood the point? > 4. PEAR doesn't include log4php.dtd Fixed in 884728. The new tutorial.pkg is still excluded but the PEAR package is not meant to used for building so that's ok. > 5. src/assembly/bin.xml has an obsolete name, src.xml would likely be > better. Fixed in 884729 > I'm thinking the cumulative is a -1 for me. Sorry I wasn't able to > pick this up sooner. Maven's RAT didn't pick up on the license > header since it doesn't check the target directory, it does if you > move target/site to doc. I don't know if standalone RAT would have > flagged it. > > I'm going to have some free time on Monday and Tuesday night, but am > likely out of touch till then. That were some well spotted issues. Maybe RC3 will finally make it :) bye, -christian-
Author: chammers
Date: Fri Nov 27 00:31:17 2009
New Revision: 884729
URL: http://svn.apache.org/viewvc?rev=884729&view=rev
Log:
renamed assembly descriptor to more descripting name
Modified:
incubator/log4php/trunk/pom.xml
Modified: incubator/log4php/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/pom.xml?rev=884729&r1=884728&r2=884729&view=diff
==============================================================================
--- incubator/log4php/trunk/pom.xml (original)
+++ incubator/log4php/trunk/pom.xml Fri Nov 27 00:31:17 2009
@@ -266,7 +266,7 @@
<artifactId>maven-assembly-plugin</artifactId>
<configuration>
<descriptors>
- <descriptor>src/assembly/bin.xml</descriptor>
+ <descriptor>src/assembly/src.xml</descriptor>
</descriptors>
<appendAssemblyId>true</appendAssemblyId>
</configuration>
Author: chammers
Date: Fri Nov 27 00:30:02 2009
New Revision: 884728
URL: http://svn.apache.org/viewvc?rev=884728&view=rev
Log:
Added missing pom.xml
Modified:
incubator/log4php/trunk/pom.xml
Modified: incubator/log4php/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/pom.xml?rev=884728&r1=884727&r2=884728&view=diff
==============================================================================
--- incubator/log4php/trunk/pom.xml (original)
+++ incubator/log4php/trunk/pom.xml Fri Nov 27 00:30:02 2009
@@ -186,7 +186,8 @@
</copy>
<copy todir="target/pear/log4php">
<fileset dir="src/main/php">
- <include name="**/*.php" />
+ <include name="**/*.php" />
+ <include name="**/*.dtd" />
</fileset>
</copy>
<exec executable="php" dir="target/pear">
Author: chammers
Date: Thu Nov 26 23:50:35 2009
New Revision: 884726
URL: http://svn.apache.org/viewvc?rev=884726&view=rev
Log:
Adds license to the phpdoc
Added:
incubator/log4php/trunk/src/main/php/tutorials/
incubator/log4php/trunk/src/main/php/tutorials/log4php/
incubator/log4php/trunk/src/main/php/tutorials/log4php/log4php.pkg
Added: incubator/log4php/trunk/src/main/php/tutorials/log4php/log4php.pkg
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/tutorials/log4php/log4php.pkg?rev=884726&view=auto
==============================================================================
--- incubator/log4php/trunk/src/main/php/tutorials/log4php/log4php.pkg (added)
+++ incubator/log4php/trunk/src/main/php/tutorials/log4php/log4php.pkg Thu Nov 26 23:50:35
2009
@@ -0,0 +1,28 @@
+<refentry id="{@id}">
+
+ <refnamediv>
+ <refname>Apache log4php</refname>
+ </refnamediv>
+
+ <refsect1 id="{@id license}">
+ <para>
+ <![CDATA[
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ ]]>
+ </para>
+ </refsect1>
+
+</refentry>
Author: chammers
Date: Thu Nov 26 23:15:52 2009
New Revision: 884719
URL: http://svn.apache.org/viewvc?rev=884719&view=rev
Log:
typo
Modified:
incubator/log4php/trunk/src/main/php/LoggerLevel.php
Modified: incubator/log4php/trunk/src/main/php/LoggerLevel.php
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/LoggerLevel.php?rev=884719&r1=884718&r2=884719&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/LoggerLevel.php (original)
+++ incubator/log4php/trunk/src/main/php/LoggerLevel.php Thu Nov 26 23:15:52 2009
@@ -21,7 +21,7 @@
/**
* Defines the minimum set of levels recognized by the system, that is
* <i>OFF</i>, <i>FATAL</i>, <i>ERROR</i>,
- * <i>WARN</i>, <i>INFO</i, <i>DEBUG</i> and
+ * <i>WARN</i>, <i>INFO</i>, <i>DEBUG</i> and
* <i>ALL</i>.
*
* <p>The <i>LoggerLevel</i> class may be subclassed to define a larger
Author: chammers
Date: Thu Nov 26 23:00:26 2009
New Revision: 884717
URL: http://svn.apache.org/viewvc?rev=884717&view=rev
Log:
Replaced "Generated Documentation" by "Apache log4php $VERSION" in apidocs.
Modified:
incubator/log4php/trunk/pom.xml
Modified: incubator/log4php/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/pom.xml?rev=884717&r1=884716&r2=884717&view=diff
==============================================================================
--- incubator/log4php/trunk/pom.xml (original)
+++ incubator/log4php/trunk/pom.xml Thu Nov 26 23:00:26 2009
@@ -226,6 +226,8 @@
<arg value="target/site/apidocs" />
<arg value="-o" />
<arg value="HTML:frames:DOM/default" />
+ <arg value="--title" />
+ <arg value="Apache log4php ${version}" />
</exec>
</tasks>
Thanks Gavin, but I think you can wait for the next RC - Curt already had some comments I want to fix Christian On Thu, Nov 26, 2009 at 11:16 AM, Gavin <gavin@16degrees.com.au> wrote: > > >> -----Original Message----- >> From: Christian Grobmeier [mailto:grobmeier@gmail.com] >> Sent: Monday, 23 November 2009 4:00 PM >> To: Log4PHP Dev >> Subject: [VOTE] Release Log4PHP-2.0.0 >> >> Dear all, >> >> please vote to release the following artifacts as version 2.0.0: >> >> [ ] +1 Yes go ahead and release the artifacts >> [ ] -1 No, because... >> >> Log4PHP 2.0.0 artifacts are available for review here: >> Â * http://people.apache.org/builds/logging/log4php/2.0.0/RC2/ >> >> The release plan used for the creation of the packages is here: >> Â * http://wiki.apache.org/logging/Log4PHP/Log4PHPReleasePlan >> >> The tag for this release is available here: >> Â * http://svn.apache.org/viewvc/incubator/log4php/tags/apache-log4php- >> 2.0.0-incubating/ >> >> Differences to the last RC: >> - license issue for the examples has been sorted out >> - corrected the wrong directory name >> - svn mv old release candidate to RC1 as tagname >> >> Please also help with checking signatures, md5 files and about all >> license stuff. A short help can be found on the release plan page. >> >> Thanks, >> Christian > > Thanks for your hard work in getting this ready. I will do my best to review > and reply over this coming weekend. > ' > Thanks > > Gav... > > >
> -----Original Message----- > From: Christian Grobmeier [mailto:grobmeier@gmail.com] > Sent: Monday, 23 November 2009 4:00 PM > To: Log4PHP Dev > Subject: [VOTE] Release Log4PHP-2.0.0 > > Dear all, > > please vote to release the following artifacts as version 2.0.0: > > [ ] +1 Yes go ahead and release the artifacts > [ ] -1 No, because... > > Log4PHP 2.0.0 artifacts are available for review here: > * http://people.apache.org/builds/logging/log4php/2.0.0/RC2/ > > The release plan used for the creation of the packages is here: > * http://wiki.apache.org/logging/Log4PHP/Log4PHPReleasePlan > > The tag for this release is available here: > * http://svn.apache.org/viewvc/incubator/log4php/tags/apache-log4php- > 2.0.0-incubating/ > > Differences to the last RC: > - license issue for the examples has been sorted out > - corrected the wrong directory name > - svn mv old release candidate to RC1 as tagname > > Please also help with checking signatures, md5 files and about all > license stuff. A short help can be found on the release plan page. > > Thanks, > Christian Thanks for your hard work in getting this ready. I will do my best to review and reply over this coming weekend. ' Thanks Gav...
> -----Original Message----- > From: Christian Grobmeier [mailto:grobmeier@gmail.com] > Sent: Wednesday, 25 November 2009 7:31 PM > To: Log4PHP Dev > Subject: Re: buildbot failure in ASF Buildbot on log4php-trunk > > Now, that I have a working account for this machine, I feel > responsible for that. > Will try to take care quite soon - sorry! no-ones fault really, but please let me know how I can help, if you want me to be around via IM or IRC when you take a look, let me know. Gav... > Christian > > On Wed, Nov 25, 2009 at 9:30 AM, <buildbot@apache.org> wrote: > > The Buildbot has detected a failed build of log4php-trunk on ASF > Buildbot. > > Full details are available at: > > http://ci.apache.org/builders/log4php-trunk/builds/270 > > > > Buildbot URL: http://ci.apache.org/ > > > > Buildslave for this Build: ceres_ubuntu > > > > Build Reason: forced: by IRC user <gmcdonald> on channel #asftest: > testing site build > > Build Source Stamp: HEAD > > Blamelist: > > > > BUILD FAILED: failed compile > > > > sincerely, > > -The Buildbot > > > > > No virus found in this incoming message. > Checked by AVG - www.avg.com > Version: 8.5.426 / Virus Database: 270.14.83/2526 - Release Date: 11/25/09 > 19:43:00
Got a couple of issues with the docs, in order of significance: 1. No "Apache", version number or incubating disclaimer on generated docs. The generated docs have a generic title "Generated Documentation" and log4php stands by itself, really should be "Apache log4php 2.0.0 (incubating)" or something like that. 2. No ASF header in generated docs From http://www.apache.org/legal/src-headers.html > What if my project includes its web site within a product distribution? > > With few exceptions, all human-readable Apache-developed files that are included within a distribution must include the header text. Documentation, including web site documentation distributed with the release, may include the header text within some form of metadata (such as HTML comments) or as a header or footer appearing in the visible documentation. Also http://incubator.apache.org/guides/releasemanagement.html#notes-license-headers > > The issue of licenses on generated documentation is a little controversial. Copyright may not subsist in a document which is generated by an transformation from an original. In which case, the license header may be unnecessary. License headers should always be present in the original. Where it is reasonable to do so, the templates should also add the license header to the generated documents. > If the license header could be templated in as an HTML comment, it would eliminate this as a point of contention. 3. Generated docs placed in target/site directory. target is the default build directory for maven. Typically, the site built with the release is placed in doc, leaving the target directory available for end-user builds. Otherwise, it is easy for a Java developer to inadvertently write over the released documentation. The "includeSiteDirectory" descriptor in Maven's assembly plugin isn't adequately described, but I'm guessing it works with the javadoc plugin and does that relocation automatically, but it doesn't do the same for phpdoc. 4. PEAR doesn't include log4php.dtd 5. src/assembly/bin.xml has an obsolete name, src.xml would likely be better. Don't know if it would be an issue, but it is included in src/main/php/xml in the source releases and not in the PEAR release. I'm thinking the cumulative is a -1 for me. Sorry I wasn't able to pick this up sooner. Maven's RAT didn't pick up on the license header since it doesn't check the target directory, it does if you move target/site to doc. I don't know if standalone RAT would have flagged it. I'm going to have some free time on Monday and Tuesday night, but am likely out of touch till then.
Hello +1 I checked gpg signatures, md5 checksums, apidocs, that tar.gz and zip contains the same files, that pear .tgz is installable and shows the right version number and that a mvn site and mvn assembly:assembly works with the unpacked sources. So far everything looked fine. bye, -christian- Am Mon, 23 Nov 2009 07:00:15 +0100 schrieb Christian Grobmeier <grobmeier@gmail.com>: > Dear all, > > please vote to release the following artifacts as version 2.0.0: > > [ ] +1 Yes go ahead and release the artifacts > [ ] -1 No, because... > > Log4PHP 2.0.0 artifacts are available for review here: > * http://people.apache.org/builds/logging/log4php/2.0.0/RC2/ > > The release plan used for the creation of the packages is here: > * http://wiki.apache.org/logging/Log4PHP/Log4PHPReleasePlan > > The tag for this release is available here: > * > http://svn.apache.org/viewvc/incubator/log4php/tags/apache-log4php-2.0.0-incubating/ > > Differences to the last RC: > - license issue for the examples has been sorted out > - corrected the wrong directory name > - svn mv old release candidate to RC1 as tagname > > Please also help with checking signatures, md5 files and about all > license stuff. A short help can be found on the release plan page. > > Thanks, > Christian
Now, that I have a working account for this machine, I feel responsible for that. Will try to take care quite soon - sorry! Christian On Wed, Nov 25, 2009 at 9:30 AM, <buildbot@apache.org> wrote: > The Buildbot has detected a failed build of log4php-trunk on ASF Buildbot. > Full details are available at: > Â http://ci.apache.org/builders/log4php-trunk/builds/270 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for this Build: ceres_ubuntu > > Build Reason: forced: by IRC user <gmcdonald> on channel #asftest: testing site build > Build Source Stamp: HEAD > Blamelist: > > BUILD FAILED: failed compile > > sincerely, > Â -The Buildbot > >
The Buildbot has detected a failed build of log4php-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/log4php-trunk/builds/270 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: ceres_ubuntu Build Reason: forced: by IRC user <gmcdonald> on channel #asftest: testing site build Build Source Stamp: HEAD Blamelist: BUILD FAILED: failed compile sincerely, -The Buildbot
Dear all, please vote to release the following artifacts as version 2.0.0: [ ] +1 Yes go ahead and release the artifacts [ ] -1 No, because... Log4PHP 2.0.0 artifacts are available for review here: * http://people.apache.org/builds/logging/log4php/2.0.0/RC2/ The release plan used for the creation of the packages is here: * http://wiki.apache.org/logging/Log4PHP/Log4PHPReleasePlan The tag for this release is available here: * http://svn.apache.org/viewvc/incubator/log4php/tags/apache-log4php-2.0.0-incubating/ Differences to the last RC: - license issue for the examples has been sorted out - corrected the wrong directory name - svn mv old release candidate to RC1 as tagname Please also help with checking signatures, md5 files and about all license stuff. A short help can be found on the release plan page. Thanks, Christian
Author: grobmeier
Date: Mon Nov 23 05:33:27 2009
New Revision: 883253
URL: http://svn.apache.org/viewvc?rev=883253&view=rev
Log:
[maven-release-plugin] prepare for next development iteration
Modified:
incubator/log4php/trunk/pom.xml
Modified: incubator/log4php/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/pom.xml?rev=883253&r1=883252&r2=883253&view=diff
==============================================================================
--- incubator/log4php/trunk/pom.xml (original)
+++ incubator/log4php/trunk/pom.xml Mon Nov 23 05:33:27 2009
@@ -19,7 +19,7 @@
<groupId>org.apache.log4php</groupId>
<artifactId>apache-log4php</artifactId>
<packaging>jar</packaging>
- <version>2.0.0-incubating</version>
+ <version>2.0.1-incubating-SNAPSHOT</version>
<name>Apache log4php.</name>
<description>Logging framework for PHP.</description>
<url>http://incubator.apache.org:80/log4php</url>
@@ -57,9 +57,9 @@
</license>
</licenses>
<scm>
- <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/log4php/tags/apache-log4php-2.0.0-incubating</connection>
- <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/log4php/tags/apache-log4php-2.0.0-incubating</developerConnection>
- <url>http://svn.apache.org/viewcvs.cgi/incubator/log4php/apache-log4php-2.0.0-incubating/tags/apache-log4php-2.0.0-incubating</url>
+ <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/log4php/trunk</connection>
+ <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/log4php/trunk</developerConnection>
+ <url>http://svn.apache.org/viewcvs.cgi/incubator/log4php/apache-log4php-2.0.0-incubating</url>
</scm>
<organization>
<name>Apache Software Foundation</name>
Author: grobmeier
Date: Mon Nov 23 05:33:12 2009
New Revision: 883252
URL: http://svn.apache.org/viewvc?rev=883252&view=rev
Log:
[maven-scm] copy for tag apache-log4php-2.0.0-incubating
Added:
incubator/log4php/tags/apache-log4php-2.0.0-incubating/
- copied from r883251, incubator/log4php/trunk/
Author: grobmeier
Date: Mon Nov 23 05:32:42 2009
New Revision: 883251
URL: http://svn.apache.org/viewvc?rev=883251&view=rev
Log:
[maven-release-plugin] prepare release apache-log4php-2.0.0-incubating
Modified:
incubator/log4php/trunk/pom.xml
Modified: incubator/log4php/trunk/pom.xml
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/pom.xml?rev=883251&r1=883250&r2=883251&view=diff
==============================================================================
--- incubator/log4php/trunk/pom.xml (original)
+++ incubator/log4php/trunk/pom.xml Mon Nov 23 05:32:42 2009
@@ -19,7 +19,7 @@
<groupId>org.apache.log4php</groupId>
<artifactId>apache-log4php</artifactId>
<packaging>jar</packaging>
- <version>2.0.0-incubating-SNAPSHOT</version>
+ <version>2.0.0-incubating</version>
<name>Apache log4php.</name>
<description>Logging framework for PHP.</description>
<url>http://incubator.apache.org:80/log4php</url>
@@ -57,9 +57,9 @@
</license>
</licenses>
<scm>
- <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/log4php/trunk</connection>
- <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/log4php/trunk</developerConnection>
- <url>http://svn.apache.org/viewcvs.cgi/incubator/log4php/apache-log4php-2.0.0-incubating</url>
+ <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/log4php/tags/apache-log4php-2.0.0-incubating</connection>
+ <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/log4php/tags/apache-log4php-2.0.0-incubating</developerConnection>
+ <url>http://svn.apache.org/viewcvs.cgi/incubator/log4php/apache-log4php-2.0.0-incubating/tags/apache-log4php-2.0.0-incubating</url>
</scm>
<organization>
<name>Apache Software Foundation</name>
> Time for RC2?
Yeah, will start on it tomorrow :)
Thanks !
>
> bye,
>
> -christian-
>
> Am Thu, 19 Nov 2009 21:38:41 -0600
> schrieb Curt Arnold <carnold@apache.org>:
>
>> The {@example} directive can optionally take an starting line number
>> (http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.inlineexample.pkg.html).
>> I've played with it with LoggerMDC.php and it would seem to allow us
>> to add the ASF source license header to the example PHP
>> and .properties files without adversely affecting the generated
>> output (unless you really need to code snippets in the docs to have
>> the leading <?php.
>>
>> I'm guessing that Doxia's snippet handler automatically closes a
>> snippet at the end of the file, so setting the line number just
>> beyond the // START SNIPPET and removing the // END SNIPPET
>> eliminates those artifacts from the phpdocs.
>>
>> The magic line number for .php files for me was 19 for .php files and
>> 18 for .properties files.
>>
>> The LoggerMDC.php contained the line "The MDC is managed on a per
>> thread basis" 3 times. Â Also, the <p><b><i> was rendered so a
literal
>> "<i>" was visible in the generated documentation. Â Bold and italic
>> and repetition seems extreme.
>
Hello
That was a good hint. I did as you suggested and now RAT is happy.
The MDC and NDC phpdoc looks proper again, too.
Time for RC2?
bye,
-christian-
Am Thu, 19 Nov 2009 21:38:41 -0600
schrieb Curt Arnold <carnold@apache.org>:
> The {@example} directive can optionally take an starting line number
> (http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.inlineexample.pkg.html).
> I've played with it with LoggerMDC.php and it would seem to allow us
> to add the ASF source license header to the example PHP
> and .properties files without adversely affecting the generated
> output (unless you really need to code snippets in the docs to have
> the leading <?php.
>
> I'm guessing that Doxia's snippet handler automatically closes a
> snippet at the end of the file, so setting the line number just
> beyond the // START SNIPPET and removing the // END SNIPPET
> eliminates those artifacts from the phpdocs.
>
> The magic line number for .php files for me was 19 for .php files and
> 18 for .properties files.
>
> The LoggerMDC.php contained the line "The MDC is managed on a per
> thread basis" 3 times. Also, the <p><b><i> was rendered so a literal
> "<i>" was visible in the generated documentation. Bold and italic
> and repetition seems extreme.