Return-Path: 
 <log4php-dev-return-2321-apmail-logging-log4php-dev-archive=logging.apache.org@logging.apache.org>
X-Original-To: apmail-logging-log4php-dev-archive@www.apache.org
Delivered-To: apmail-logging-log4php-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C217272A1
	for <apmail-logging-log4php-dev-archive@www.apache.org>;
 Tue, 15 Nov 2011 07:40:19 +0000 (UTC)
Received: (qmail 32189 invoked by uid 500); 15 Nov 2011 07:40:17 -0000
Delivered-To: apmail-logging-log4php-dev-archive@logging.apache.org
Received: (qmail 32085 invoked by uid 500); 15 Nov 2011 07:40:16 -0000
Mailing-List: contact log4php-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:log4php-dev-help@logging.apache.org>
list-unsubscribe: <mailto:log4php-dev-unsubscribe@logging.apache.org>
List-Post: <mailto:log4php-dev@logging.apache.org>
Reply-To: "Log4PHP Dev" <log4php-dev@logging.apache.org>
List-Id: <log4php-dev.logging.apache.org>
Delivered-To: mailing list log4php-dev@logging.apache.org
Received: (qmail 32058 invoked by uid 99); 15 Nov 2011 07:40:14 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Nov 2011 07:40:14 +0000
X-ASF-Spam-Status: No, hits=-2001.2 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Nov 2011 07:40:12 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id E0B4D8427F
	for <log4php-dev@logging.apache.org>; Tue, 15 Nov 2011 07:39:52 +0000 (UTC)
Date: Tue, 15 Nov 2011 07:39:52 +0000 (UTC)
From: "Florian Semm (Commented) (JIRA)" <jira@apache.org>
To: log4php-dev@logging.apache.org
Message-ID: 
 <907371361.30036.1321342792921.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <370329028.29995.1321342551509.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (LOG4PHP-162) Warning for invalid appender
 threshold level never called
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/LOG4PHP-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150284#comment-13150284 ] 

Florian Semm commented on LOG4PHP-162:
--------------------------------------

i think all warnings which related to invalid-levels could be removed.

for instance the root-logger config :

{code}
if (isset($config['level'])) {
			$level = LoggerLevel::toLevel($config['level']);
			if (isset($level)) {
				$logger->setLevel($level);
			} else {
				$default = $logger->getLevel();
				$this->warn("Invalid logger level [{$config['level']}] specified for logger [$loggerName].");
			}
		}
{code}

$level is always set.
                
> Warning for invalid appender threshold level never called
> ---------------------------------------------------------
>
>                 Key: LOG4PHP-162
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-162
>             Project: Log4php
>          Issue Type: Improvement
>          Components: Code
>    Affects Versions: 2.1
>            Reporter: Florian Semm
>            Priority: Minor
>             Fix For: 2.2
>
>
> appender config:
> <appender name="foo" class="LoggerAppenderConsole" threshold="FOO" />
> Expected warning: "Invalid threshold value [FOO]..."
> LoggerLevel::toLevel() return always level-debug if default-level is null. If the threshold unknow the default-level (debug in this case) will be returned. There is no need for this warning in line 266-267 LoggerConfigurator.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira