logging-log4php-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Florian Semm <florian.s...@gmx.de>
Subject Re: trigger errors
Date Wed, 16 Nov 2011 07:27:38 GMT
Am 14.11.2011 14:53, schrieb Ivan Habunek:
> On 13 November 2011 14:39, Florian Semm<florian.semm@gmx.de>  wrote:
>> the configurator and the adapters are good examples for separation of
>> concerns. :)
>>
>> the configurator-test only has tests for two error-cases, happy-path and
>> default-setup. i would like to write some addional testcases.
> That would be very welcome. I spent a lot of time on the code and
> tests, but tests are still in need of some attention.
>
> Regards,
> Ivan
the coverage of the LoggerConfigurator is now at 90%. May I commit my tests?

btw: there was no check if a the specified rendererClass/renderingClass 
exists. I fixed this in my tests too.


regards,

florian

Mime
View raw message