logging-log4php-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Grobmeier (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LOG4PHP-79) AppenderPDO: Some database fields seem a bit too short
Date Wed, 09 Sep 2009 09:25:59 GMT

    [ https://issues.apache.org/jira/browse/LOG4PHP-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752996#action_12752996

Christian Grobmeier commented on LOG4PHP-79:

I totally agree.

We just need to make sure to have some kind of standard sql which is beeing understood at
least for the most databases. Maybe we need to write some more code for independency.

> AppenderPDO: Some database fields seem a bit too short
> ------------------------------------------------------
>                 Key: LOG4PHP-79
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-79
>             Project: Log4php
>          Issue Type: Improvement
>          Components: Code
>            Reporter: Christian Hammers
> The default CREATAE TABLE statement in LoggerAppenderPDO is:
>                 $query = "CREATE TABLE {$this->table} (  timestamp varchar(32)," .
   "logger varchar(32)," .
   "level varchar(32)," .
   "message varchar(64)," .
   "thread varchar(32)," .
   "file varchar(64)," .
   "line varchar(4) );";
> It seems to me that 64 chars for the filename and message are a bit short.
> Even our examples are so deeply nested that the .php from the file name got cut off.
> I won't even think of a typical log message.
> I would propose to go for varchar(255) or even text ("clob") for message, varchar(255)
for file and "int unsigned" for line (currently it looks like "9999 lines show be enough for
everyone!" :) 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message