logging-log4net-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tom Nichols <tmnich...@gmail.com>
Subject Re: Checking IsDebugEnabled before calling Debug()?
Date Fri, 18 Nov 2005 14:49:48 GMT

I was going through the examples and saw this:
       // Log a debug message. Test if debug is enabled before
       // attempting to log the message. This is not required but
       // can make running without logging faster.
       if (log.IsDebugEnabled) log.Debug("This is a debug message");

My question is, why not just check this in LogImpl.Debug() , i.e.
       virtual public void Debug(object message)
               if( this.IsDebugEnabled ) Logger.Log(ThisDeclaringType,
m_levelDebug, message, null);

And then of course do the same for DebugFormat, Info, Warn, etc. etc.
I haven't dug much into the code but I'm interested in using the
framework.  It just seems to me that if you really get a performance
enhancement from testing if IsDebugEnabled before calling it, it would
make more sense to save that step everywhere you make that Debug()
call in paractice.

I'm guessing there's a good reason why, but could someone tell me?


View raw message