logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominik Psenner (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LOG4NET-553) DebugAppender configuration should give the possibility to disable outputting loggerName as category
Date Fri, 10 Feb 2017 16:07:41 GMT

    [ https://issues.apache.org/jira/browse/LOG4NET-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861461#comment-15861461
] 

Dominik Psenner edited comment on LOG4NET-553 at 2/10/17 4:07 PM:
------------------------------------------------------------------

Largely agreed, I would further handle the special case of empty category:

{code}
if m_category == null
  call Debug.Write(string)
else
  category = m_category.Format(loggingEvent)
  if string.Empty.Equals(category)
    call Debug.Write(string)
  else
    call Debug.Write(string, category)
{code}

Sorry for the additional roundtrip and thanks for your time! ;-)


was (Author: nachbarslumpi):
Largely agreed, I would further handle the special case of empty category specially:

{code}
if m_category == null
  call Debug.Write(string)
else
  category = m_category.Format(loggingEvent)
  if string.Empty.Equals(category)
    call Debug.Write(string)
  else
    call Debug.Write(string, category)
{code}

Sorry for the additional roundtrip and thanks for your time! ;-)

> DebugAppender configuration should give the possibility to disable outputting loggerName
as category
> ----------------------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-553
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-553
>             Project: Log4net
>          Issue Type: New Feature
>          Components: Appenders
>    Affects Versions: 2.0.7
>            Reporter: Jean-Francois Beaulac
>         Attachments: log4net-DebugAppenderCategory2.patch, log4net-DebugAppenderCategory.patch,
OutputCategoryParam-DebugAppender.cs.patch
>
>
> The DebugAppender always uses the {{System.Diagnostics.Debug.Write(string,string)}} overload
passing in the loggername as the category parameter.
> It should be possible to omit the category parameter if having the loggername as category
is not desired.
> Attached is a patch implementing the desired new feature, which would be activated by
configuration:
> {code:xml}
> <appender name="DEBUG" type="log4net.Appender.DebugAppender">
>     <outputCategory value="false"/>
>     <layout type="log4net.Layout.PatternLayout">
> 	  <conversionPattern value="%-5level: %message%newline"/>
>     </layout>
>   </appender>
> {code}
> In my patch, the outputCategory parameter defaults to true, so the behavior doesnt change
unless the new configuration is used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message