logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JJoe2 <...@git.apache.org>
Subject [GitHub] log4net issue #35: Wip/app settings
Date Wed, 26 Oct 2016 18:52:16 GMT
Github user JJoe2 commented on the issue:

    https://github.com/apache/log4net/pull/35
  
    I’ll be happy to do the unit tests and possibly the doc.   Are suitable XML comments
enough?
    
    Now this is added, I’ll also be thinking about the next step, which is to allow the
PatternString converter to be used in the XML configuration file for properties of types other
than strings.
    So that I can do something like:
    
        <root>
           <level type=”log4net.Util.PatternString” value="%appsetting{Logging. Level}"
/>
       </root>
    
    Should be possible: basically be applying the PatternString conversion before converting
to the target type of the property.
    
    From: Stefan Bodewig [mailto:notifications@github.com]
    Sent: 26 October 2016 20:43
    To: apache/log4net
    Cc: JJoe2; Author
    Subject: Re: [apache/log4net] Wip/app settings (#35)
    
    
    I've added your converter, many thanks.
    
    Tests would be good and we need documentation before we can close LOG4NET-526.
    
    —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub<https://github.com/apache/log4net/pull/35#issuecomment-256440366>,
or mute the thread<https://github.com/notifications/unsubscribe-auth/AFY0uybBZ6IZdXI75BhcToQlNLFlHQY3ks5q359EgaJpZM4KMD7s>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message