logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] log4net issue #25: API to flush appenders that buffer logging data
Date Thu, 13 Oct 2016 05:58:04 GMT
Github user bodewig commented on the issue:

    https://github.com/apache/log4net/pull/25
  
    I've ensured all line-ends are consistent and set to native in svn trunk - git is not
our primary repository, https://svn.apache.org/repos/asf/logging/log4net/trunk/ is. If you've
got access to svn maybe it is a better idea to develop your patch against it and attach it
to JIRA. Using the traditional way :-)
    
    I'd really prefer we don't add any new methods to existing interfaces as this may break
custom implementations. That's why I didn't want `Flush` in `ILoggerRepository`. We can't
know who has implemented the interface in library or application code. `LoggerManager` could
check whether `ILoggerRepository` implemented `IFlushable` and simply don't do anything in
its `Flush` implementation if it didn't.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message