logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JJoe2 <...@git.apache.org>
Subject [GitHub] log4net issue #25: API to flush appenders that buffer logging data
Date Wed, 12 Oct 2016 20:53:29 GMT
Github user JJoe2 commented on the issue:

    https://github.com/apache/log4net/pull/25
  
    Hi Stefan,
    
    Thanks for the feedback.
    
    As you’ll have gathered I’m a novice as far as Git and Github are concerned, though
slightly less so than I was when I created this patch.
    
    I’ll take a look this weekend and try to produce something better that can be merged
directly, and separate the patches for the different pull requests (UTC; Flush; …).
    
    I suspect the whitespace issues may be caused by different CRLF standards, though I’m
surprised the diff utility doesn’t ignore such differences.  IIRC Visual Studio popped up
a dialog about inconsistent line endings and offered to fix it.   If you have any tips on
how to handle this I’m all ears, otherwise I’m sure I’ll work it out for myself.
    
    The LogManager.Flush() method is implemented as:
    
                    LoggerManager.GetRepository(Assembly.GetCallingAssembly()).Flush();
    
    How would you propose to implement this if the Flush method was moved out of ILoggerRepository?
    
    From: Stefan Bodewig [mailto:notifications@github.com]
    Sent: 12 October 2016 22:32
    To: apache/log4net
    Cc: JJoe2; Author
    Subject: Re: [apache/log4net] API to flush appenders that buffer logging data (#25)
    
    
    This PR seems to include #24<https://github.com/apache/log4net/pull/24> as well,
could you provide a patch without it?
    
    Also, I'm not sure why Flush has been added to ILoggerRepository directly. It would be
better if LoggerRepositorySkeleton implemented IFlushable IMHO.
    
    The whitespace changes are distracting, it is difficult to see the differences in lots
of classes.
    
    —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub<https://github.com/apache/log4net/pull/25#issuecomment-253330546>,
or mute the thread<https://github.com/notifications/unsubscribe-auth/AFY0u7no2CA1aE7ZfZEWE9hxc_YACHeHks5qzUPcgaJpZM4IOSN6>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message