Mailing-List: contact log4net-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4NET Dev" <log4net-dev@logging.apache.org>
Date: Wed, 24 Aug 2016 17:09:20 +0000 (UTC)
From: "Dominik Psenner (JIRA)" <jira@apache.org>
To: log4net-dev@logging.apache.org
Message-ID: <JIRA.12999702.1472052602000.399225.1472058560631@Atlassian.JIRA>
In-Reply-To: <JIRA.12999702.1472052602000@Atlassian.JIRA>
References: <JIRA.12999702.1472052602000@Atlassian.JIRA> <JIRA.12999702.1472052602614@arcas>
Subject: [jira] [Commented] (LOG4NET-524) OnlyOnceErrorHandler might cause
 StackOverflowError
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 24 Aug 2016 17:09:22 -0000


    [ https://issues.apache.org/jira/browse/LOG4NET-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435303#comment-15435303 ] 

Dominik Psenner commented on LOG4NET-524:
-----------------------------------------

Please subscribe to the log4j mailing list to track notifications and get involved. I do not actively hack on log4j and will most likely loose track of this.

> OnlyOnceErrorHandler might cause StackOverflowError
> ---------------------------------------------------
>
>                 Key: LOG4NET-524
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-524
>             Project: Log4net
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.15
>            Reporter: Marc Theisen
>            Assignee: Dominik Psenner
>
> I am referring to the solution in https://bz.apache.org/bugzilla/show_bug.cgi?id=42151.
> I am suggesting another approach instead of placing a bad hack into com.{{csfb.fao.carat.util.file.LoggingOutputStream}}.
> Why not change the {{error}} method of class {{OnlyOnceErrorHandler}} from
> {code}
> public void error(String message, Exception e, int errorCode, LoggingEvent event)
> {
>   if (e instanceof InterruptedIOException || e instanceof InterruptedException)
>   {
>     Thread.currentThread().interrupt();
>   }
>   if(firstTime)
>   {
>     LogLog.error(message, e);
>     firstTime = false;           // yikes, too late if stdout/stderr has been
>   }                              // redirected
> }
> {code}
> to
> {code}
> public void error(String message, Exception e, int errorCode, LoggingEvent event)
> {
>   if (e instanceof InterruptedIOException || e instanceof InterruptedException)
>   {
>     Thread.currentThread().interrupt();
>   }
>   if(firstTime)
>   {
>     firstTime = false;
>     LogLog.error(message, e);
>   }
> }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)