logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dominik Psenner <dpsen...@gmail.com>
Subject Re: PluginMap survives LoggerRepositorySkeleton.ResetConfiguration()
Date Mon, 22 Aug 2016 20:37:47 GMT
Hard to tell. Worst case is that we implicitly break code that relies on
plugins to stay where they are. It seems logical to me that
ResetConfiguration() should reset all the configuration. Now one could
argue that plugins are not part of the configuration, but rather something
that provides functionality and gets configured. So ResetConfiguration
logically should not purge plugins, but should purge the configuration of
these plugins.

2016-08-22 14:44 GMT+02:00 <Jonas.Baehr@rohde-schwarz.com>:

> Hi,
>
> LoggerRepositorySkeleton.ResetConfiguration() does not clear its plugin
> map, while all other structures (render map, level map) are cleared. Is
> there a special reason for that or is it a bug? Note that the plugins are
> shutdown in LoggerRepositorySkeleton.Shutdown, though.
> Currently I have to remove the plugins manually, to "Reset the
> repositories configuration to a default state" (quote from the API docs of
> `ResetConfiguration` ).
>
> The attached patch changes the logger repository skeleton to also reset
> the plugin map at `RestConfiguration`. The question is: Is this the right
> way to do, or are there strong reasons for the plugins to stay? I could not
> find anything in the revision log; this code basically didn't change since
> the initial commit in january 2004.
>
> Regards,
> Jonas
>
>


-- 
Dominik Psenner

Mime
View raw message