logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arun Kumar <arun.kumar...@hotmail.com>
Subject RE: [jira] [Commented] (LOG4NET-524) OnlyOnceErrorHandler might cause StackOverflowError
Date Sat, 27 Aug 2016 11:36:30 GMT
Unsubscribe

Sent from my Windows Phone
________________________________
From: Dominik Psenner (JIRA)<mailto:jira@apache.org>
Sent: ‎24-‎08-‎2016 22:39
To: log4net-dev@logging.apache.org<mailto:log4net-dev@logging.apache.org>
Subject: [jira] [Commented] (LOG4NET-524) OnlyOnceErrorHandler might cause StackOverflowError


    [ https://issues.apache.org/jira/browse/LOG4NET-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435303#comment-15435303
]

Dominik Psenner commented on LOG4NET-524:
-----------------------------------------

Please subscribe to the log4j mailing list to track notifications and get involved. I do not
actively hack on log4j and will most likely loose track of this.

> OnlyOnceErrorHandler might cause StackOverflowError
> ---------------------------------------------------
>
>                 Key: LOG4NET-524
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-524
>             Project: Log4net
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.15
>            Reporter: Marc Theisen
>            Assignee: Dominik Psenner
>
> I am referring to the solution in https://bz.apache.org/bugzilla/show_bug.cgi?id=42151.
> I am suggesting another approach instead of placing a bad hack into com.{{csfb.fao.carat.util.file.LoggingOutputStream}}.
> Why not change the {{error}} method of class {{OnlyOnceErrorHandler}} from
> {code}
> public void error(String message, Exception e, int errorCode, LoggingEvent event)
> {
>   if (e instanceof InterruptedIOException || e instanceof InterruptedException)
>   {
>     Thread.currentThread().interrupt();
>   }
>   if(firstTime)
>   {
>     LogLog.error(message, e);
>     firstTime = false;           // yikes, too late if stdout/stderr has been
>   }                              // redirected
> }
> {code}
> to
> {code}
> public void error(String message, Exception e, int errorCode, LoggingEvent event)
> {
>   if (e instanceof InterruptedIOException || e instanceof InterruptedException)
>   {
>     Thread.currentThread().interrupt();
>   }
>   if(firstTime)
>   {
>     firstTime = false;
>     LogLog.error(message, e);
>   }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message