logging-log4net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dominik Psenner <dpsen...@gmail.com>
Subject Re: [jira] [Commented] (LOG4NET-473) Option for file extension in SmtpPickupDirAppender
Date Sun, 01 Nov 2015 11:08:13 GMT
At first glance this looks good. But i will need some time to get my hands
on a computer.
On 1 Nov 2015 11:48 a.m., "Albin Sunnanbo (JIRA)" <jira@apache.org> wrote:

>
>     [
> https://issues.apache.org/jira/browse/LOG4NET-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984343#comment-14984343
> ]
>
> Albin Sunnanbo commented on LOG4NET-473:
> ----------------------------------------
>
> Hi again
> It looks like my SVN skills have been decaying. Sorry for that.
> I found the GIT-version of the source and supplied a fixed version of the
> above patch as a pull request in https://github.com/apache/log4net/pull/19
> I also created a basic test for the SmtpPickupDirAppender in
> https://github.com/apache/log4net/pull/17
>
> Additionally I created a pull request for generating a Date header in
> https://github.com/apache/log4net/pull/18
> I prefer separate pull requests for each feature in GIT, but if you prefer
> the contribution as a single pull request or an SVN path I can fix that.
>
> > Option for file extension in SmtpPickupDirAppender
> > --------------------------------------------------
> >
> >                 Key: LOG4NET-473
> >                 URL: https://issues.apache.org/jira/browse/LOG4NET-473
> >             Project: Log4net
> >          Issue Type: New Feature
> >    Affects Versions: 1.2.13
> >            Reporter: Albin Sunnanbo
> >         Attachments: SmtpPickupDirAppender-fileextension.patch
> >
> >
> > Especially on Windows file extensions are very handy, if you give the
> output files the `eml` extension you can just double click the file to open
> the mail in outlook.
> > I have added a `FileExtension` option to the `SmtpPickupDirAppender`
> that can be used to specify a file extension for the generated files.
> > Although a default value of `eml` would be nice I have preserved
> backwards compatibility of no file extension by default.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>

Mime
View raw message